Prohibit LayoutInline from being relayout boundary

Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328
Committed: https://crrev.com/72473efe964b34ed70910de4cc59c6295cc63019
Cr-Commit-Position: refs/heads/master@{#439656}

[kojii, 2016-12-19 04:46:40]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 04:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-19 05:16:18]

Description was changed from

==========
contain-inline

BUG=671328
==========

to

==========
Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328
==========

[kojii, 2016-12-19 05:45:50]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 05:46:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-19 05:46:19]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-19 07:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 07:06:44]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-12-19 07:44:38]

kojii@chromium.org changed reviewers:
+ pdr@chromium.org, szager@chromium.org

[kojii, 2016-12-19 07:44:39]

szager@, pdr@, could you PTAL while eae@ is OOO?

Adding RELEASE_ASSERT as suggested in https://crbug.com/671328#c12 is at
http://crrev.com/2587863002, to catch other possible errors, but this is the
real fix.

[szager1, 2016-12-19 19:52:39]

lgtm

[pdr., 2016-12-19 19:52:49]

On 2016/12/19 at 07:44:39, kojii wrote:
> szager@, pdr@, could you PTAL while eae@ is OOO?
> 
> Adding RELEASE_ASSERT as suggested in https://crbug.com/671328#c12 is at
http://crrev.com/2587863002, to catch other possible errors, but this is the
real fix.

I think this is reasonable. LGTM

[kojii, 2016-12-20 01:29:07]

Thank you both!

[kojii, 2016-12-20 01:29:36]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-12-20 01:30:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:35:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482197376168720,
"parent_rev": "e79d57039482df069100cf65107ed5aa0d6a924e", "commit_rev":
"bc6130f835ba510955196798a764157782236048"}

[commit-bot: I haz the power, 2016-12-20 01:36:35]

Description was changed from

==========
Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328
==========

to

==========
Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328

Review-Url: https://codereview.chromium.org/2586853002
==========

[commit-bot: I haz the power, 2016-12-20 01:36:35]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-20 01:39:26]

Description was changed from

==========
Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328

Review-Url: https://codereview.chromium.org/2586853002
==========

to

==========
Prohibit LayoutInline from being relayout boundary

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328

Committed: https://crrev.com/72473efe964b34ed70910de4cc59c6295cc63019
Cr-Commit-Position: refs/heads/master@{#439656}
==========

[commit-bot: I haz the power, 2016-12-20 01:39:27]

Patchset 1 (id:??) landed as
https://crrev.com/72473efe964b34ed70910de4cc59c6295cc63019
Cr-Commit-Position: refs/heads/master@{#439656}

[esprehn, 2016-12-20 01:43:55]

Can you explain the fix? How does start layout at the inline result in this bug?
:)

[kojii, 2016-12-20 04:37:06]

On 2016/12/20 at 01:43:55, esprehn wrote:
> Can you explain the fix? How does start layout at the inline result in this
bug? :)

LayoutInline::layout() is no-op, so it ends up with needsLayout() after layout()
(the test hits ASSERT_NOT_REACHED and several !needsLayout() DCHECK such as in
assertLaidOut().)

HTMLSelectElement::optionElementChildrenChanged() updates LayoutText, but since
it's not laid out yet, InlineTextBox is still old and has old index/length.