Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2586853002: Prohibit LayoutInline from being relayout boundary (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/containment/inline-contain-layout-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 689
690 static inline bool objectIsRelayoutBoundary(const LayoutObject* object) { 690 static inline bool objectIsRelayoutBoundary(const LayoutObject* object) {
691 // FIXME: In future it may be possible to broaden these conditions in order to 691 // FIXME: In future it may be possible to broaden these conditions in order to
692 // improve performance. 692 // improve performance.
693 if (object->isTextControl()) 693 if (object->isTextControl())
694 return true; 694 return true;
695 695
696 if (object->isSVGRoot()) 696 if (object->isSVGRoot())
697 return true; 697 return true;
698 698
699 // LayoutInline can't be relayout roots since LayoutBlockFlow is responsible
700 // for layouting them.
701 if (object->isLayoutInline())
702 return false;
703
699 // Table parts can't be relayout roots since the table is responsible for 704 // Table parts can't be relayout roots since the table is responsible for
700 // layouting all the parts. 705 // layouting all the parts.
701 if (object->isTablePart()) 706 if (object->isTablePart())
702 return false; 707 return false;
703 708
704 if (object->style()->containsLayout() && object->style()->containsSize()) 709 if (object->style()->containsLayout() && object->style()->containsSize())
705 return true; 710 return true;
706 711
707 if (!object->hasOverflowClip()) 712 if (!object->hasOverflowClip())
708 return false; 713 return false;
(...skipping 2799 matching lines...) Expand 10 before | Expand all | Expand 10 after
3508 const blink::LayoutObject* root = object1; 3513 const blink::LayoutObject* root = object1;
3509 while (root->parent()) 3514 while (root->parent())
3510 root = root->parent(); 3515 root = root->parent();
3511 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3516 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3512 } else { 3517 } else {
3513 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3518 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3514 } 3519 }
3515 } 3520 }
3516 3521
3517 #endif 3522 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/containment/inline-contain-layout-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698