Issue 2586813003: Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2586813003: Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. (Closed)

Created:
4 years ago by vasilii

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. The two histograms replace PasswordManager.SignInPromoCountTilClick. It used to record the same number for both buttons. BUG=672163 Review-Url: https://codereview.chromium.org/2578923003 Cr-Commit-Position: refs/heads/master@{#439075} (cherry picked from commit 6fa168c33de7fa32366602594cc4ccd313874650) Committed: https://chromium.googlesource.com/chromium/src/+/00221931c858bb0a9af2294da8bba3d2c1e5b87e

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -18 lines)			Patch
M	chrome/browser/ui/passwords/manage_passwords_bubble_model.cc	View	1 chunk	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc	View	5 chunks	+12 lines, -6 lines	0 comments	Download
M	components/password_manager/core/browser/password_manager_metrics_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_manager_metrics_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

vasilii

4 years ago (2016-12-19 11:53:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00221931c858bb0a9af2294da8bba3d2c1e5b87e.