Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble.

chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
@@ skipping 30 matching lines @@
 using password_bubble_experiment::kSmartLockBrandingGroupName;
 using password_bubble_experiment::kSmartLockBrandingSavePromptOnlyGroupName;
 using ::testing::AnyNumber;
 using ::testing::Return;
 using ::testing::ReturnRef;
 using ::testing::_;
 
 namespace {
 
 const char kFakeGroup[] = "FakeGroup";
-const char kSignInPromoCountTilClickMetric[] =
-    "PasswordManager.SignInPromoCountTilClick";
+const char kSignInPromoCountTilNoThanksMetric[] =
+    "PasswordManager.SignInPromoCountTilNoThanks";
+const char kSignInPromoCountTilSignInMetric[] =
+    "PasswordManager.SignInPromoCountTilSignIn";
 const char kSignInPromoDismissalCountMetric[] =
     "PasswordManager.SignInPromoDismissalCount";
 const char kSignInPromoDismissalReasonMetric[] = "PasswordManager.SignInPromo";
 const char kSiteOrigin[] = "http://example.com/login";
 const char kUsername[] = "Admin";
 const char kUIDismissalReasonMetric[] = "PasswordManager.UIDismissalReason";
 
 class TestSyncService : public browser_sync::ProfileSyncServiceMock {
  public:
   explicit TestSyncService(Profile* profile)
@@ skipping 305 matching lines @@
 TEST_F(ManagePasswordsBubbleModelTest, SuppressSignInPromo) {
   base::HistogramTester histogram_tester;
   PretendPasswordWaiting();
   EXPECT_CALL(*GetStore(), RemoveSiteStatsImpl(GURL(kSiteOrigin).GetOrigin()));
   EXPECT_CALL(*controller(), SavePassword());
   model()->OnSaveClicked();
 
   EXPECT_FALSE(model()->ReplaceToShowSignInPromoIfNeeded());
   DestroyModel();
   histogram_tester.ExpectTotalCount(kSignInPromoDismissalReasonMetric, 0);
-  histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
   histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, SignInPromoOK) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup));
   variations::AssociateVariationParams(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup,
       {{kChromeSignInPasswordPromoThresholdParam, "3"}});
   base::HistogramTester histogram_tester;
   PretendPasswordWaiting();
   EXPECT_CALL(*GetStore(), RemoveSiteStatsImpl(GURL(kSiteOrigin).GetOrigin()));
   EXPECT_CALL(*controller(), SavePassword());
   model()->OnSaveClicked();
 
   EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());
   EXPECT_CALL(*controller(), NavigateToChromeSignIn());
   model()->OnSignInToChromeClicked();
   DestroyModel();
   histogram_tester.ExpectUniqueSample(
       kUIDismissalReasonMetric,
       password_manager::metrics_util::CLICKED_SAVE, 1);
   histogram_tester.ExpectUniqueSample(
       kSignInPromoDismissalReasonMetric,
       password_manager::metrics_util::CHROME_SIGNIN_OK, 1);
-  histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
+  histogram_tester.ExpectUniqueSample(kSignInPromoCountTilSignInMetric, 1, 1);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
   histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
   EXPECT_TRUE(prefs()->GetBoolean(
       password_manager::prefs::kWasSignInPasswordPromoClicked));
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, SignInPromoCancel) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup));
   variations::AssociateVariationParams(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup,
       {{kChromeSignInPasswordPromoThresholdParam, "3"}});
   base::HistogramTester histogram_tester;
   PretendPasswordWaiting();
   EXPECT_CALL(*GetStore(), RemoveSiteStatsImpl(GURL(kSiteOrigin).GetOrigin()));
   EXPECT_CALL(*controller(), SavePassword());
   model()->OnSaveClicked();
 
   EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());
   model()->OnSkipSignInClicked();
   DestroyModel();
   histogram_tester.ExpectUniqueSample(
       kUIDismissalReasonMetric,
       password_manager::metrics_util::CLICKED_SAVE, 1);
   histogram_tester.ExpectUniqueSample(
       kSignInPromoDismissalReasonMetric,
       password_manager::metrics_util::CHROME_SIGNIN_CANCEL, 1);
-  histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
+  histogram_tester.ExpectUniqueSample(kSignInPromoCountTilNoThanksMetric, 1, 1);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
   histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
   EXPECT_TRUE(prefs()->GetBoolean(
       password_manager::prefs::kWasSignInPasswordPromoClicked));
 }
 
 TEST_F(ManagePasswordsBubbleModelTest, SignInPromoDismiss) {
   ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup));
   variations::AssociateVariationParams(
       kChromeSignInPasswordPromoExperimentName, kFakeGroup,
       {{kChromeSignInPasswordPromoThresholdParam, "3"}});
   base::HistogramTester histogram_tester;
   PretendPasswordWaiting();
   EXPECT_CALL(*GetStore(), RemoveSiteStatsImpl(GURL(kSiteOrigin).GetOrigin()));
   EXPECT_CALL(*controller(), SavePassword());
   model()->OnSaveClicked();
 
   EXPECT_TRUE(model()->ReplaceToShowSignInPromoIfNeeded());
   DestroyModel();
   histogram_tester.ExpectUniqueSample(
       kUIDismissalReasonMetric,
       password_manager::metrics_util::CLICKED_SAVE, 1);
   histogram_tester.ExpectUniqueSample(
       kSignInPromoDismissalReasonMetric,
       password_manager::metrics_util::CHROME_SIGNIN_DISMISSED, 1);
-  histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
+  histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
   histogram_tester.ExpectUniqueSample(kSignInPromoDismissalCountMetric, 1, 1);
   EXPECT_FALSE(prefs()->GetBoolean(
       password_manager::prefs::kWasSignInPasswordPromoClicked));
 }
 
 namespace {
 
 enum class SmartLockStatus { ENABLE, DISABLE };
 
 struct TitleTestCase {
@@ skipping 106 matching lines @@
      ManageLinkTarget::SETTINGS_PAGE},
     {nullptr, SmartLockStatus::DISABLE, ManageLinkTarget::SETTINGS_PAGE},
     {"Default", SmartLockStatus::DISABLE, ManageLinkTarget::SETTINGS_PAGE},
 };
 
 }  // namespace
 
 INSTANTIATE_TEST_CASE_P(Default,
                         ManagePasswordsBubbleModelManageLinkTest,
                         ::testing::ValuesIn(kManageLinkTestCases));