[Downloads] Add a horizontal material-styled ProgressBar

[Downloads] Add a horizontal material-styled ProgressBar

The support library's ProgressBar doesn't support JB or KK,
and the ToolbarProgressBar doesn't support JB.  In the
tradition of re-inventing the wheel, introduce a ProgressBar
that is styled according to Material Design that works on all
versions of Android that Clank supports.

* Introduce the MaterialProgressBar, which mimics the Material
  Design spec on how horizontal progress bars are supposed to
  look for both determinate and indeterminate modes.

* Switch DownloadItemView and SpaceDisplay to use the newfangled
  widget, then nuke unnecessary styling.

* Delete old, unused, experimental ProgressBars.

Video:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZGtzU3FxMGFMWlU/view?usp=sharing

BUG=658246
Committed: https://crrev.com/afb0abd44f95e654b68553097db825e4771b2cfa
Cr-Commit-Position: refs/heads/master@{#440287}

[gone, 2016-12-17 02:15:09]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-12-17 02:17:23]

Ian: Just sending this out before I forget; don't look at it yet.  Still need to
run some tests on JB.

[gone, 2016-12-19 22:55:44]

Welp, I can't even test on JB because my local builds refuse to run on two
different devices.  PTAL while I sort that out :/

[Ian Wen, 2016-12-20 23:17:58]

Looks good overall. Wish we could drop the support for determinate progress bar.

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/attrs.xml (right):

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/attrs.xml:64: <attr name="colorThrobber"
format="reference|color" />
Try removing this if it is not critical?

Also it would make more sense that we could refer the "dim blue" as the
background, and the "darker blue" as the foreground?

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java
(right):

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java:148:
drawDeterminateBar(canvas);
Not sure if we need to support determinate bar in this case. IIUC we could
pretty much achieve it by changing the colors of the progress bar on K and J.

[gone, 2016-12-21 00:54:24]

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/attrs.xml (right):

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/attrs.xml:64: <attr name="colorThrobber"
format="reference|color" />
On 2016/12/20 23:17:58, Ian Wen wrote:
> Try removing this if it is not critical?
> 
> Also it would make more sense that we could refer the "dim blue" as the
> background, and the "darker blue" as the foreground?

Dropped the throbber specification; just using a bar colored using colorProgress
on top of the bar that's the background color.

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java
(right):

https://codereview.chromium.org/2586643002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java:148:
drawDeterminateBar(canvas);
On 2016/12/20 23:17:58, Ian Wen wrote:
> Not sure if we need to support determinate bar in this case. IIUC we could
> pretty much achieve it by changing the colors of the progress bar on K and J.

We could, but I'm going for an all encompassing solution here instead of having
two progress bars that the developer has to swap out depending on what's being
shown.

[gone, 2016-12-21 19:22:05]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:47:18]

Dry run: This issue passed the CQ dry run.

[Ian Wen, 2016-12-21 23:17:27]

lgtm

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/download_item_view.xml (right):

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/download_item_view.xml:108:
chrome:colorBackground="@color/google_grey_400"
Up to you, optional, nit:

Maybe we could set these colors as default and most users of this class won't
bother to set these values repetitively.

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java
(right):

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java:47:
public class MaterialProgressBar extends View implements AnimatorUpdateListener
{
Another random, optional, up-to-you nit. :)

It might help make this class shorter by extending ProgressBar instead of View.
This way you don't need to maintain a setProgress() and getProgress() method
yourself. Also this way you can make this class as a drop-in replacement for
anybody who's willing to migrate (if any).

[gone, 2016-12-22 00:58:38]

Going to submit this to get some builds to test with, but can revisit after the
holidays.

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/download_item_view.xml (right):

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/download_item_view.xml:108:
chrome:colorBackground="@color/google_grey_400"
On 2016/12/21 23:17:27, Ian Wen wrote:
> Up to you, optional, nit:
> 
> Maybe we could set these colors as default and most users of this class won't
> bother to set these values repetitively.

Worth revisiting when it's more than just downloads using this, I think.  The
current implementation uses whatever defaults are defined for regular progress
bars in colors.xml.

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java
(right):

https://codereview.chromium.org/2586643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/MaterialProgressBar.java:47:
public class MaterialProgressBar extends View implements AnimatorUpdateListener
{
On 2016/12/21 23:17:27, Ian Wen wrote:
> Another random, optional, up-to-you nit. :)
> 
> It might help make this class shorter by extending ProgressBar instead of
View.
> This way you don't need to maintain a setProgress() and getProgress() method
> yourself. Also this way you can make this class as a drop-in replacement for
> anybody who's willing to migrate (if any).

I didn't want to have to deal with the baggage and unintentional side effects of
inheriting from something it overrides everything for :/

[gone, 2016-12-22 00:58:44]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:59:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:04:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482368324683210,
"parent_rev": "7f997f02bb7e25054f051fa72116662a259f1312", "commit_rev":
"44dbae9e40823b410a1be44c56106f4dcc8f1ba4"}

[commit-bot: I haz the power, 2016-12-22 01:04:29]

Description was changed from

==========
[Downloads] Add a horizontal material-styled ProgressBar

The support library's ProgressBar doesn't support JB or KK,
and the ToolbarProgressBar doesn't support JB.  In the
tradition of re-inventing the wheel, introduce a ProgressBar
that is styled according to Material Design that works on all
versions of Android that Clank supports.

* Introduce the MaterialProgressBar, which mimics the Material
  Design spec on how horizontal progress bars are supposed to
  look for both determinate and indeterminate modes.

* Switch DownloadItemView and SpaceDisplay to use the newfangled
  widget, then nuke unnecessary styling.

* Delete old, unused, experimental ProgressBars.

Video:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZGtzU3FxMGFMWlU/v...

BUG=658246
==========

to

==========
[Downloads] Add a horizontal material-styled ProgressBar

The support library's ProgressBar doesn't support JB or KK,
and the ToolbarProgressBar doesn't support JB.  In the
tradition of re-inventing the wheel, introduce a ProgressBar
that is styled according to Material Design that works on all
versions of Android that Clank supports.

* Introduce the MaterialProgressBar, which mimics the Material
  Design spec on how horizontal progress bars are supposed to
  look for both determinate and indeterminate modes.

* Switch DownloadItemView and SpaceDisplay to use the newfangled
  widget, then nuke unnecessary styling.

* Delete old, unused, experimental ProgressBars.

Video:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZGtzU3FxMGFMWlU/v...

BUG=658246

Review-Url: https://codereview.chromium.org/2586643002
==========

[commit-bot: I haz the power, 2016-12-22 01:04:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 01:09:51]

Description was changed from

==========
[Downloads] Add a horizontal material-styled ProgressBar

The support library's ProgressBar doesn't support JB or KK,
and the ToolbarProgressBar doesn't support JB.  In the
tradition of re-inventing the wheel, introduce a ProgressBar
that is styled according to Material Design that works on all
versions of Android that Clank supports.

* Introduce the MaterialProgressBar, which mimics the Material
  Design spec on how horizontal progress bars are supposed to
  look for both determinate and indeterminate modes.

* Switch DownloadItemView and SpaceDisplay to use the newfangled
  widget, then nuke unnecessary styling.

* Delete old, unused, experimental ProgressBars.

Video:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZGtzU3FxMGFMWlU/v...

BUG=658246

Review-Url: https://codereview.chromium.org/2586643002
==========

to

==========
[Downloads] Add a horizontal material-styled ProgressBar

The support library's ProgressBar doesn't support JB or KK,
and the ToolbarProgressBar doesn't support JB.  In the
tradition of re-inventing the wheel, introduce a ProgressBar
that is styled according to Material Design that works on all
versions of Android that Clank supports.

* Introduce the MaterialProgressBar, which mimics the Material
  Design spec on how horizontal progress bars are supposed to
  look for both determinate and indeterminate modes.

* Switch DownloadItemView and SpaceDisplay to use the newfangled
  widget, then nuke unnecessary styling.

* Delete old, unused, experimental ProgressBars.

Video:
https://drive.google.com/a/chromium.org/file/d/0B8k2SmEN8xS3ZGtzU3FxMGFMWlU/v...

BUG=658246

Committed: https://crrev.com/afb0abd44f95e654b68553097db825e4771b2cfa
Cr-Commit-Position: refs/heads/master@{#440287}
==========

[commit-bot: I haz the power, 2016-12-22 01:09:51]

Patchset 2 (id:??) landed as
https://crrev.com/afb0abd44f95e654b68553097db825e4771b2cfa
Cr-Commit-Position: refs/heads/master@{#440287}