Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/android/java/res/layout/download_item_view.xml

Issue 2586643002: [Downloads] Add a horizontal material-styled ProgressBar (Closed)
Patch Set: Get rid of specialized throbber color Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/download_item_view.xml
diff --git a/chrome/android/java/res/layout/download_item_view.xml b/chrome/android/java/res/layout/download_item_view.xml
index 679d1f85dbf244d5086f63075c786d367191a5bf..1210f0f4efd73937c888117884f8affe82c519ad 100644
--- a/chrome/android/java/res/layout/download_item_view.xml
+++ b/chrome/android/java/res/layout/download_item_view.xml
@@ -96,16 +96,18 @@
android:textColor="@color/default_text_color"
android:textSize="14sp" />
- <ProgressBar
+ <org.chromium.chrome.browser.widget.MaterialProgressBar
android:id="@+id/download_progress_view"
- style="@style/DownloadProgressBar"
android:layout_width="wrap_content"
android:layout_height="2dp"
android:layout_marginTop="5dp"
android:layout_marginBottom="5dp"
android:layout_below="@+id/filename_progress_view"
android:layout_alignParentStart="true"
- android:layout_toStartOf="@+id/pause_button" />
+ android:layout_toStartOf="@+id/pause_button"
+ chrome:colorBackground="@color/google_grey_400"
Ian Wen 2016/12/21 23:17:27 Up to you, optional, nit: Maybe we could set thes
gone 2016/12/22 00:58:38 Worth revisiting when it's more than just download
+ chrome:colorProgress="@color/light_active_color"
+ chrome:colorSecondaryProgress="@color/google_grey_600" />
<TextView
android:id="@+id/status_view"

Powered by Google App Engine
This is Rietveld 408576698