Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2586163002: Remove string representation values from DateTimeChooser interfaces. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove string representation values from DateTimeChooser interfaces. They are not used. This CL has no behavior changes. Committed: https://crrev.com/b3ad717afe828265281046496d67dc1e8ce7c4d6 Cr-Commit-Position: refs/heads/master@{#439688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeChooser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebDateTimeChooserCompletion.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebDateTimeChooserParams.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
kochi@, would you review this please?
4 years ago (2016-12-19 08:47:04 UTC) #6
kochi
lgtm
4 years ago (2016-12-20 03:06:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586163002/1
4 years ago (2016-12-20 03:06:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 03:11:27 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 03:13:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3ad717afe828265281046496d67dc1e8ce7c4d6
Cr-Commit-Position: refs/heads/master@{#439688}

Powered by Google App Engine
This is Rietveld 408576698