Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp

Issue 2586163002: Remove string representation values from DateTimeChooser interfaces. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
diff --git a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
index 8c4a5a34fd173ba2c1b36a51b28d9aefb708793b..31d6ef21d8ad4fb4d5785bb458ea5c5392825e66 100644
--- a/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
+++ b/third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp
@@ -42,11 +42,6 @@ class WebDateTimeChooserCompletionImpl : public WebDateTimeChooserCompletion {
: m_chooser(chooser) {}
private:
- void didChooseValue(const WebString& value) override {
- m_chooser->didChooseValue(value);
- delete this;
- }
-
void didChooseValue(double value) override {
m_chooser->didChooseValue(value);
delete this;
@@ -111,7 +106,6 @@ bool ExternalDateTimeChooser::openDateTimeChooser(
WebDateTimeChooserParams webParams;
webParams.type = toWebDateTimeInputType(parameters.type);
webParams.anchorRectInScreen = parameters.anchorRectInScreen;
- webParams.currentValue = parameters.currentValue;
webParams.doubleValue = parameters.doubleValue;
webParams.suggestions = parameters.suggestions;
webParams.minimum = parameters.minimum;

Powered by Google App Engine
This is Rietveld 408576698