Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437
Committed: https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570
Cr-Commit-Position: refs/heads/master@{#440651}

[Byoungkwon Ko, 2016-12-18 14:06:29]

Description was changed from

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function.

BUG=675437
==========

to

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437
==========

[Byoungkwon Ko, 2016-12-19 17:53:31]

gogag2@gmail.com changed reviewers:
+ foolip@chromium.org, jinho.bang@samsung.com

[Byoungkwon Ko, 2016-12-19 17:53:42]

PTAL

[Byoungkwon Ko, 2016-12-19 17:53:44]

PTAL

[zino, 2016-12-19 18:02:31]

I left some comments.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html
(right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html:27:
}, 'DOMPointReadOnly.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a
DOMPointReadOnly');
nit: should create

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html
(right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:65:
test(() => {
I think you should add one more test to check whether the fromPoint() always
returns a new object.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:68:
}, 'DOMPoint.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a DOMPoint');
nit: should create

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPoint.h (right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPoint.h:21: static DOMPoint*
fromPoint(DOMPointInit&);
nit: const DOMPointInit?

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPointReadOnly.h:22: static
DOMPointReadOnly* fromPoint(DOMPointInit&);
nit: const DOMPointInit?

[Byoungkwon Ko, 2016-12-19 18:59:42]

Plz review this cl again.
Thanks : )

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html
(right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html:27:
}, 'DOMPointReadOnly.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a
DOMPointReadOnly');
On 2016/12/19 18:02:31, zino wrote:
> nit: should create

Done.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html:27:
}, 'DOMPointReadOnly.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a
DOMPointReadOnly');
On 2016/12/19 18:02:31, zino wrote:
> nit: should create

Done.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html
(right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:65:
test(() => {
On 2016/12/19 18:02:31, zino wrote:
> I think you should add one more test to check whether the fromPoint() always
> returns a new object.

Done.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html:68:
}, 'DOMPoint.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a DOMPoint');
On 2016/12/19 18:02:31, zino wrote:
> nit: should create

Done.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPoint.h (right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPoint.h:21: static DOMPoint*
fromPoint(DOMPointInit&);
On 2016/12/19 18:02:31, zino wrote:
> nit: const DOMPointInit?

Done.

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/2586083002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMPointReadOnly.h:22: static
DOMPointReadOnly* fromPoint(DOMPointInit&);
On 2016/12/19 18:02:31, zino wrote:
> nit: const DOMPointInit?

Done.

[zino, 2016-12-19 19:03:21]

lgtm

foolip@, Could you please review this?
If you OOO til Jan. 2, BK will find other core's reviewer. :)

[Byoungkwon Ko, 2016-12-21 05:19:02]

Dear zino

I think foolip is out of office until Jan. 2;
Could you tell me other core's reviewer?
Thanks.

[Byoungkwon Ko, 2016-12-22 04:08:15]

gogag2@gmail.com changed reviewers:
+ haraken@chromium.org

[Byoungkwon Ko, 2016-12-22 04:08:33]

PTAL

[zino, 2016-12-22 07:33:52]

On 2016/12/22 04:08:33, Byoungkwon Ko wrote:
> PTAL

PTAL haraken@

This is a trivial change and the feature is still behind runtime flag.
dominicc@ and foolip@ are OOO for a long time.

[haraken, 2016-12-22 07:36:28]

LGTM

[zino, 2016-12-23 02:16:01]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 02:16:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 04:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 04:58:03]

Dry run: This issue passed the CQ dry run.

[Byoungkwon Ko, 2016-12-23 04:59:12]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2016-12-23 04:59:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2586083002/#ps120001
(title: "Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following
spec.")

[commit-bot: I haz the power, 2016-12-23 04:59:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 05:04:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 05:04:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zino, 2016-12-23 17:27:42]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 17:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 19:10:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 19:10:21]

Dry run: This issue passed the CQ dry run.

[Byoungkwon Ko, 2016-12-23 19:18:40]

The CQ bit was checked by gogag2@gmail.com

[Byoungkwon Ko, 2016-12-23 19:18:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jinho.bang@samsung.com
Link to the patchset: https://codereview.chromium.org/2586083002/#ps140001
(title: "adfasdf")

[commit-bot: I haz the power, 2016-12-23 19:18:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 19:22:21]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482520720954010,
"parent_rev": "78a008f3728df1535c3f312695bb32aa5ff35c16", "commit_rev":
"b5b5da8897f3b9bbfeea29c61ddbee8623e91c7b"}

[commit-bot: I haz the power, 2016-12-23 19:22:49]

Description was changed from

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437
==========

to

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437

Review-Url: https://codereview.chromium.org/2586083002
==========

[commit-bot: I haz the power, 2016-12-23 19:22:50]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-23 19:25:18]

Description was changed from

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437

Review-Url: https://codereview.chromium.org/2586083002
==========

to

==========
Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

The two interfaces require fromPoint function as following spec[1].

[1] https://drafts.fxtf.org/geometry/#dom-dompointreadonly-frompoint

BUG=675437

Committed: https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570
Cr-Commit-Position: refs/heads/master@{#440651}
==========

[commit-bot: I haz the power, 2016-12-23 19:25:19]

Patchset 8 (id:??) landed as
https://crrev.com/1f450a4b3e7db1497563deb7ad4e6bf25e228570
Cr-Commit-Position: refs/heads/master@{#440651}

[Byoungkwon Ko, 2016-12-26 23:58:23]

Patchset #8 (id:140001) has been deleted

[Byoungkwon Ko, 2016-12-28 00:16:49]

Patchset #8 (id:160001) has been deleted