third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html - Issue 2586083002: Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point.html

Issue 2586083002: Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec. (Closed)

Patch Set: Adding fromPoint to DOMPoint and DOMPointReadOnly interfaces following spec. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html » ('j') | third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-point-readonly.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <meta charset="utf-8">	2 <meta charset="utf-8">

3 <title>Geometry Interfaces: DOMPoint</title>	3 <title>Geometry Interfaces: DOMPoint</title>

4 <link rel="help" href="https://drafts.fxtf.org/geometry/#DOMPoint">	4 <link rel="help" href="https://drafts.fxtf.org/geometry/#DOMPoint">

5 <script src="../../resources/testharness.js"></script>	5 <script src="../../resources/testharness.js"></script>

6 <script src="../../resources/testharnessreport.js"></script>	6 <script src="../../resources/testharnessreport.js"></script>

7 <script src="./resources/geometry-interfaces-test-helpers.js"></script>	7 <script src="./resources/geometry-interfaces-test-helpers.js"></script>

8 <script>	8 <script>

9 'use strict';	9 'use strict';

10	10

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 test(() => {	56 test(() => {

57 var point = new DOMPoint();	57 var point = new DOMPoint();

58 point.x = 10;	58 point.x = 10;

59 point.y = 20;	59 point.y = 20;

60 point.z = 30;	60 point.z = 30;

61 point.w = 40;	61 point.w = 40;

62 assert_dom_point_equals(point, [10, 20, 30, 40]);	62 assert_dom_point_equals(point, [10, 20, 30, 40]);

63 }, 'DOMPoint setter');	63 }, 'DOMPoint setter');

64	64

65 </script>	65 test(() => {
	zino 2016/12/19 18:02:31 I think you should add one more test to check whet I think you should add one more test to check whether the fromPoint() always returns a new object. Byoungkwon Ko 2016/12/19 18:59:42 Done. Show quoted text On 2016/12/19 18:02:31, zino wrote: > I think you should add one more test to check whether the fromPoint() always > returns a new object. Done.
	66 var point = DOMPoint.fromPoint({x: 1, y: 2, z: 3, w: 4});

	67 assert_dom_point_equals(point, [1, 2, 3, 4]);

	68 }, 'DOMPoint.fromPoint({x: 1, y: 2, z: 3, w: 4}) should creat a DOMPoint');
	zino 2016/12/19 18:02:31 nit: should create nit: should create Byoungkwon Ko 2016/12/19 18:59:42 Done. Show quoted text On 2016/12/19 18:02:31, zino wrote: > nit: should create Done.
	69

	70 </script>

OLD	NEW