[UI Cocoa] Hide the global error bubble icon from accessibility

[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350
Committed: https://crrev.com/5ff7749fe5dc00161a93cecc43058a5c5fa6a33b
Cr-Commit-Position: refs/heads/master@{#439362}

[Devlin, 2016-12-17 00:20:05]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-12-17 00:21:18]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2016-12-17 00:21:18]

Avi, mind taking a look?

+cc dmazzoni and lgarron.

I don't know of any easy way to test this (e.g., the view is still returned from
the accessible children attribute).  If you can think of any, I'm all ears. :)

[Avi (use Gerrit), 2016-12-17 03:22:43]

lgtm

Dunno.

[Devlin, 2016-12-18 01:17:31]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-12-18 01:17:43]

Description was changed from

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
whiel using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350
==========

to

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350
==========

[commit-bot: I haz the power, 2016-12-18 01:17:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 02:22:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482023851745080,
"parent_rev": "a0ab929e7fafb79def391bc84a90a8d303dbdfe2", "commit_rev":
"225f697d4ba322a852ce6a4c596383e290e595fc"}

[commit-bot: I haz the power, 2016-12-18 02:23:49]

Description was changed from

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350
==========

to

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350

Review-Url: https://codereview.chromium.org/2585953002
==========

[commit-bot: I haz the power, 2016-12-18 02:23:50]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-12-18 02:26:35]

Description was changed from

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350

Review-Url: https://codereview.chromium.org/2585953002
==========

to

==========
[UI Cocoa] Hide the global error bubble icon from accessibility

The icon in the global error bubble currently only specifies "Image"
while using voice over. Since each of these dialogs provide a title
that makes the image relatively superfluous, remove the image entirely
from the accessibility tree.

Add a new utility function to do this generically in Cocoa, and use it
in the website settings bubble controller as well.

BUG=670350

Committed: https://crrev.com/5ff7749fe5dc00161a93cecc43058a5c5fa6a33b
Cr-Commit-Position: refs/heads/master@{#439362}
==========

[commit-bot: I haz the power, 2016-12-18 02:26:36]

Patchset 1 (id:??) landed as
https://crrev.com/5ff7749fe5dc00161a93cecc43058a5c5fa6a33b
Cr-Commit-Position: refs/heads/master@{#439362}