[UI Cocoa] Hide the global error bubble icon from accessibility

chrome/browser/ui/cocoa/global_error_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/global_error_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "chrome/browser/ui/browser.h"
 #import "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/app_menu/app_menu_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 #import "chrome/browser/ui/cocoa/l10n_util.h"
 #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"
 #include "chrome/browser/ui/global_error/global_error.h"
 #include "chrome/browser/ui/global_error/global_error_bubble_view_base.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
 #include "components/search_engines/util.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
+#import "ui/base/cocoa/a11y_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image.h"
 
 namespace {
 const CGFloat kParagraphSpacing = 6;
 } // namespace
 
 namespace GlobalErrorBubbleControllerInternal {
 
 // This is the bridge to the C++ GlobalErrorBubbleViewBase object.
@@ skipping 37 matching lines @@
 }
 
 - (void)awakeFromNib {
   [super awakeFromNib];
 
   DCHECK(error_);
 
   gfx::Image image = error_->GetBubbleViewIcon();
   DCHECK(!image.IsEmpty());
   [iconView_ setImage:image.ToNSImage()];
+  // So far, none of these icons have useful descriptions (they only specify
+  // "image"). Hide them from the accessibility order for voice over. If any
+  // new bubbles use this for an informational icon, we can add a new method
+  // to the GlobalErrorWithStandardBubble class.
+  ui::a11y_util::HideImageFromAccessibilityOrder(iconView_);
 
   [title_ setStringValue:SysUTF16ToNSString(error_->GetBubbleViewTitle())];
   std::vector<base::string16> messages = error_->GetBubbleViewMessages();
   base::string16 message = base::JoinString(messages, base::ASCIIToUTF16("\n"));
 
   base::scoped_nsobject<NSMutableAttributedString> messageValue(
       [[NSMutableAttributedString alloc]
           initWithString:SysUTF16ToNSString(message)]);
   base::scoped_nsobject<NSMutableParagraphStyle> style(
       [[NSMutableParagraphStyle alloc] init]);
@@ skipping 61 matching lines @@
   [self close];
 }
 
 @end
 
 GlobalErrorBubbleViewBase* GlobalErrorBubbleViewBase::ShowStandardBubbleView(
     Browser* browser,
     const base::WeakPtr<GlobalErrorWithStandardBubble>& error) {
   return [GlobalErrorBubbleController showForBrowser:browser error:error];
 }