Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2585693002: [serializer] allocate global proxy with the expected size. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] allocate global proxy with the expected size. If a context snapshot includes the global proxy constructor function, we expect the incoming global proxy to have the correct instance size so that we can reinitialize it with said constructor. However, when the bootstrapper allocates a new global proxy, we need to know the expected size. We solve this by storing the size on the to-be-serialized isolate. R=jochen@chromium.org, peria@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2585693002 Cr-Commit-Position: refs/heads/master@{#41756} Committed: https://chromium.googlesource.com/v8/v8/+/55e8c2e4d3c5f79295a7bfb1ca929e14541f28fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M src/api.cc View 3 chunks +14 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +16 lines, -6 lines 0 comments Download
M src/heap/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Yang
4 years ago (2016-12-16 09:22:28 UTC) #1
Yang
On 2016/12/16 09:22:28, Yang wrote: Can I haz review? :)
4 years ago (2016-12-16 11:51:13 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-16 11:59:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585693002/1
4 years ago (2016-12-16 11:59:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/55e8c2e4d3c5f79295a7bfb1ca929e14541f28fe
4 years ago (2016-12-16 12:40:44 UTC) #12
peria
4 years ago (2016-12-18 16:58:15 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698