[serializer] add test for snapshotting cached accessor property.

[serializer] add test for snapshotting cached accessor property.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
Review-Url: https://codereview.chromium.org/2582623003
Cr-Commit-Position: refs/heads/master@{#41761}
Committed: https://chromium.googlesource.com/v8/v8/+/d2d6da035400893c7a90e928eb63f1fdd9b55b65

[jochen (gone - plz use gerrit), 2016-12-16 10:19:06]

lgtm

[jochen (gone - plz use gerrit), 2016-12-16 11:43:23]

forgot to publish my drafts

https://codereview.chromium.org/2582623003/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):

https://codereview.chromium.org/2582623003/diff/1/test/cctest/test-serialize....
test/cctest/test-serialize.cc:2403: CHECK(context->Global()
can you also test that setting this after deserializing will work?

[Yang, 2016-12-16 11:57:45]

On 2016/12/16 11:43:23, jochen wrote:
> forgot to publish my drafts
> 
>
https://codereview.chromium.org/2582623003/diff/1/test/cctest/test-serialize.cc
> File test/cctest/test-serialize.cc (right):
> 
>
https://codereview.chromium.org/2582623003/diff/1/test/cctest/test-serialize....
> test/cctest/test-serialize.cc:2403: CHECK(context->Global()
> can you also test that setting this after deserializing will work?

Done. Also added test for private symbol returned from v8::Private::ForApi.

[Yang, 2016-12-16 12:43:32]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-16 12:43:33]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2582623003/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-12-16 12:43:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 13:25:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481892212920500,
"parent_rev": "89f159b0420d643ecc78d43db0f7836d3c4aa932", "commit_rev":
"d2d6da035400893c7a90e928eb63f1fdd9b55b65"}

[commit-bot: I haz the power, 2016-12-16 13:25:26]

Description was changed from

==========
[serializer] add test for snapshotting cached accessor property.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

to

==========
[serializer] add test for snapshotting cached accessor property.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892

Review-Url: https://codereview.chromium.org/2582623003
Cr-Commit-Position: refs/heads/master@{#41761}
Committed:
https://chromium.googlesource.com/v8/v8/+/d2d6da035400893c7a90e928eb63f1fdd9b...
==========

[commit-bot: I haz the power, 2016-12-16 13:25:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d2d6da035400893c7a90e928eb63f1fdd9b...

[peria, 2016-12-18 16:55:49]

lgtm