Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2585283002: Migrate WTF::Vector::append() to ::push_back() [part 6 of N] (Closed)

Created:
4 years ago by pilgrim_google
Modified:
4 years ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, dcheng, gavinp+loader_chromium.org, Nate Chapin, kinuko+fileapi, loading-reviews+fetch_chromium.org, mlamouri+watch-blink_chromium.org, nhiroki, tyoshino+watch_chromium.org, tzik, Yoav Weiss, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Vector::append() to ::push_back() [part 6 of N] As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces append() with push_back() in Source/core/events/, fetch/, fileapi/, and frame/. There are too many references to change them all at once, so this CL is part 6 of many. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Committed: https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de Cr-Commit-Position: refs/heads/master@{#439480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -125 lines) Patch
M third_party/WebKit/Source/core/events/EventListenerMap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventPath.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventSender.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/GenericEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/ScopedEventQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TreeScopeEventContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/TreeScopeEventContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/HostsUsingFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Location.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SmartClip.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveListTest.cpp View 8 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp View 5 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pilgrim_google
4 years ago (2016-12-19 14:16:41 UTC) #3
pilgrim_google
4 years ago (2016-12-19 14:16:52 UTC) #5
haraken
LGTM
4 years ago (2016-12-19 15:11:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585283002/1
4 years ago (2016-12-19 15:28:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 15:52:27 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-19 15:55:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de
Cr-Commit-Position: refs/heads/master@{#439480}

Powered by Google App Engine
This is Rietveld 408576698