third_party/WebKit/Source/core/frame/RemoteFrame.cpp - Issue 2585283002: Migrate WTF::Vector::append() to ::push_back() [part 6 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 2585283002: Migrate WTF::Vector::append() to ::push_back() [part 6 of N] (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

index 730c0173cb6fe224b77de40146eb40aaaf9142c1..558aed7e956e07363603fffee4ddc80e5ebdc11c 100644

--- a/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/RemoteFrame.cpp

@@ -193,7 +193,7 @@ void RemoteFrame::detachChildren() {

childrenToDetach.reserveCapacity(tree().childCount());

for (Frame* child = tree().firstChild(); child;

child = child->tree().nextSibling())

- childrenToDetach.append(child);

+ childrenToDetach.push_back(child);

for (const auto& child : childrenToDetach)

child->detach(FrameDetachType::Remove);

}