Don't limit 'Login not secure' warning to password fields

Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Committed: https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef
Cr-Commit-Position: refs/heads/master@{#439837}

[estark, 2016-12-19 20:56:59]

Description was changed from

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too! Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.
==========

to

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.
==========

[estark, 2016-12-19 20:57:41]

estark@chromium.org changed reviewers:
+ vabr@chromium.org

[estark, 2016-12-19 20:57:41]

vabr, can you please review? Thanks!

[vabr (Chromium), 2016-12-20 07:26:37]

LGTM, thanks!
Vaclav

https://codereview.chromium.org/2585173006/diff/1/components/autofill_strings...
File components/autofill_strings.grdp (right):

https://codereview.chromium.org/2585173006/diff/1/components/autofill_strings...
components/autofill_strings.grdp:197: <message
name="IDS_AUTOFILL_LOGIN_HTTP_WARNING_MESSAGE" desc="Chrome can help the user
fill login web forms by showing a pop-up with text suggestions next to a focused
text field. If the form is on an insecure site (e.g., http://), this text is
shown on top of those suggestions.">
just a note (no action needed):
In the team we use the phrase "password form" to denote any form containing a
password field, whereas a "login form" is one used for signing in (as opposed to
changing passwords or signing up).
But that's just the team's use, not sure how the translators understand these
terms. To me both versions seem reasonable.

[vabr (Chromium), 2016-12-20 07:26:43]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 07:27:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 07:29:05]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[estark, 2016-12-20 16:45:10]

https://codereview.chromium.org/2585173006/diff/1/components/autofill_strings...
File components/autofill_strings.grdp (right):

https://codereview.chromium.org/2585173006/diff/1/components/autofill_strings...
components/autofill_strings.grdp:197: <message
name="IDS_AUTOFILL_LOGIN_HTTP_WARNING_MESSAGE" desc="Chrome can help the user
fill login web forms by showing a pop-up with text suggestions next to a focused
text field. If the form is on an insecure site (e.g., http://), this text is
shown on top of those suggestions.">
On 2016/12/20 07:26:37, vabr (Chromium) wrote:
> just a note (no action needed):
> In the team we use the phrase "password form" to denote any form containing a
> password field, whereas a "login form" is one used for signing in (as opposed
to
> changing passwords or signing up).
> But that's just the team's use, not sure how the translators understand these
> terms. To me both versions seem reasonable.

Ah, thanks, that's good to know!

[estark, 2016-12-20 16:45:25]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-12-20 16:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 17:39:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482252325290400, "parent_rev":
"aa5772f0f6538d08e031bc7eaf45e2deab94f5bd", "commit_rev":
"729260231539a78627a19dfd052e87c43f3846ba"}

[commit-bot: I haz the power, 2016-12-20 17:40:06]

Description was changed from

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.
==========

to

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
==========

[commit-bot: I haz the power, 2016-12-20 17:40:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-20 17:41:40]

Description was changed from

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Review-Url: https://codereview.chromium.org/2585173006
==========

to

==========
Don't limit 'Login not secure' warning to password fields

Per the specs at go/fns-ui-spec, the "Login not secure" warning should
show up in username fields as well as password fields. Which makes sense
because usernames are sensitive information too. Thus, this CL populates
the "Login not secure" warning in the suggestions dropdown of a password
form regardless of whether the field is a password field or not.

BUG=675696
TEST=Enable #enable-http-form-warning in chrome://flags and relaunch
Chrome. Save a username/password in the Name/Password form in
http://rsolomakhin.github.io/autofill/. Focus the "Name" field and
observe a "Login not secure" warning in the autofill dropdown.

Committed: https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef
Cr-Commit-Position: refs/heads/master@{#439837}
==========

[commit-bot: I haz the power, 2016-12-20 17:41:41]

Patchset 1 (id:??) landed as
https://crrev.com/c97dee453dac00aaf5a24441a3a371efee1d43ef
Cr-Commit-Position: refs/heads/master@{#439837}