Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2584903003: [android_webview] Register a dummy binder for autofill::mojom::PasswordManagerDriver (Closed)

Created:
4 years ago by leonhsl(Using Gerrit)
Modified:
4 years ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Register a dummy binder for autofill::mojom::PasswordManagerDriver Although WebView does not support password manager feature, renderer code could still request this interface, so we register a dummy binder which just drops the incoming request, to avoid the 'Failed to locate a binder for interface' error log. BUG=662040 Committed: https://crrev.com/5f1bacb6d4ee52aca467b5d9b1ae35d5d5f5790b Cr-Commit-Position: refs/heads/master@{#439659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
leonhsl(Using Gerrit)
This CL comes up from Ken's suggestion at https://bugs.chromium.org/p/chromium/issues/detail?id=662040#c52, would you PTAL? Thanks!
4 years ago (2016-12-19 02:05:08 UTC) #6
boliu
lgtm
4 years ago (2016-12-19 17:19:35 UTC) #7
leonhsl(Using Gerrit)
On 2016/12/19 17:19:35, boliu wrote: > lgtm Thank you! And supposing Ken has no big ...
4 years ago (2016-12-20 01:22:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584903003/1
4 years ago (2016-12-20 01:22:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 01:44:58 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 01:49:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f1bacb6d4ee52aca467b5d9b1ae35d5d5f5790b
Cr-Commit-Position: refs/heads/master@{#439659}

Powered by Google App Engine
This is Rietveld 408576698