Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6504)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2584903003: [android_webview] Register a dummy binder for autofill::mojom::PasswordManagerDriver (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index a6bb56546a7109084126a3105ee4849681f6040c..b87bb97be5e3e3293d9ebbbfed719d103347de7f 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -158,6 +158,10 @@ void AwContentsMessageFilter::OnSubFrameCreated(int parent_render_frame_id,
AwLocaleManager* g_locale_manager = NULL;
+// A dummy binder for mojo interface autofill::mojom::PasswordManagerDriver.
+void DummyBindPasswordManagerDriver(
+ autofill::mojom::PasswordManagerDriverRequest request) {}
+
} // anonymous namespace
// TODO(yirui): can use similar logic as in PrependToAcceptLanguagesIfNecessary
@@ -551,6 +555,12 @@ void AwContentBrowserClient::RegisterRenderFrameMojoInterfaces(
registry->AddInterface(
base::Bind(&autofill::ContentAutofillDriverFactory::BindAutofillDriver,
render_frame_host));
+
+ // Although WebView does not support password manager feature, renderer code
+ // could still request this interface, so we register a dummy binder which
+ // just drops the incoming request, to avoid the 'Failed to locate a binder
+ // for interface' error log..
+ registry->AddInterface(base::Bind(&DummyBindPasswordManagerDriver));
}
} // namespace android_webview
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698