Use explicit WebString <-> string16 conversion methods in media files

Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
Committed: https://crrev.com/4a18cc0132fce0c9668989f4153851c5389657fa
Cr-Commit-Position: refs/heads/master@{#439736}

[kinuko, 2016-12-16 15:56:59]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:57:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2016-12-16 16:01:04]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 16:01:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:45:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:45:33]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-12-17 02:26:19]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

[kinuko, 2016-12-17 02:26:19]

kinuko@chromium.org changed reviewers:
+ ddorwin@chromium.org

[kinuko, 2016-12-17 02:27:14]

Hi, could you review this change?  (Mostly mechanical)

https://codereview.chromium.org/2584893002/diff/20001/content/renderer/media/...
File content/renderer/media/canvas_capture_handler.cc (right):

https://codereview.chromium.org/2584893002/diff/20001/content/renderer/media/...
content/renderer/media/canvas_capture_handler.cc:260: const blink::WebString
track_id = blink::WebString::fromASCII(str_track_id);
Looks like str_track_id is ASCII-only

https://codereview.chromium.org/2584893002/diff/20001/content/renderer/media/...
File content/renderer/media/midi_message_filter.cc (right):

https://codereview.chromium.org/2584893002/diff/20001/content/renderer/media/...
content/renderer/media/midi_message_filter.cc:225:
WebString::fromUTF8(info.version), info.state);
If some of these could be guaranteed to be ascii we can also use fromASCII for
these.

[ddorwin, 2016-12-17 03:09:12]

ddorwin@chromium.org changed reviewers:
+ jrummell@chromium.org
- ddorwin@chromium.org

[ddorwin, 2016-12-17 03:09:47]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2016-12-17 03:09:47]

=> jrummell

[ddorwin, 2016-12-17 03:10:10]

ddorwin@chromium.org changed reviewers:
- ddorwin@chromium.org

[jrummell, 2016-12-19 21:27:47]

lgtm

[kinuko, 2016-12-20 05:31:17]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2016-12-20 05:31:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:47:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482211877244430,
"parent_rev": "c7e9c86283e317325ab1db7151432ca6549801b5", "commit_rev":
"2e94177b01e569cd469e9736ba3de9ac10b183cc"}

[commit-bot: I haz the power, 2016-12-20 07:48:04]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2584893002
==========

[commit-bot: I haz the power, 2016-12-20 07:48:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 07:49:46]

Description was changed from

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2584893002
==========

to

==========
Use explicit WebString <-> string16 conversion methods in media files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Committed: https://crrev.com/4a18cc0132fce0c9668989f4153851c5389657fa
Cr-Commit-Position: refs/heads/master@{#439736}
==========

[commit-bot: I haz the power, 2016-12-20 07:49:47]

Patchset 2 (id:??) landed as
https://crrev.com/4a18cc0132fce0c9668989f4153851c5389657fa
Cr-Commit-Position: refs/heads/master@{#439736}