content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc - Issue 2584893002: Use explicit WebString <-> string16 conversion methods in media files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

Issue 2584893002: Use explicit WebString <-> string16 conversion methods in media files (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/midi_message_filter.cc ('K') | « content/renderer/media/midi_message_filter.cc ('k') | content/renderer/media/peer_connection_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

diff --git a/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc b/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

index 825a212f42bf24953f8db4628f24da3ef1716eec..0180f58a9435d0abcbb372907dbf0f7da40d28c7 100644

--- a/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

+++ b/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc

@@ -32,10 +32,9 @@ MockWebRTCPeerConnectionHandlerClient::

void MockWebRTCPeerConnectionHandlerClient::didGenerateICECandidateWorker(

const blink::WebRTCICECandidate& candidate) {

if (!candidate.isNull()) {

- candidate_sdp_ =

- base::UTF16ToUTF8(base::StringPiece16(candidate.candidate()));

+ candidate_sdp_ = candidate.candidate().utf8();

candidate_mline_index_ = candidate.sdpMLineIndex();

- candidate_mid_ = base::UTF16ToUTF8(base::StringPiece16(candidate.sdpMid()));

+ candidate_mid_ = candidate.sdpMid().utf8();

} else {

candidate_sdp_ = "";

candidate_mline_index_ = -1;