Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2584063002: Re-land: Toggle spoken feedback if two fingers are held down. (Closed)

Created:
4 years ago by dmazzoni
Modified:
4 years ago
Reviewers:
sadrul, xiyuan, oshima, michaelpg
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Toggle spoken feedback if two fingers are held down. Originally landed in r432129 and r434618, reverted in r435519 because it was triggering too often. Re-landing this time but modifying it to only apply to Chromebox For Meetings devices. Original CL: https://codereview.chromium.org/2476843003 BUG=662501, 667439 TBR=oshima,sadrul,michaelpg CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3 Cr-Commit-Position: refs/heads/master@{#439611}

Patch Set 1 #

Patch Set 2 : Only toggle spoken feedback on CFM devices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+584 lines, -6 lines) Patch
M ash/ash_touch_exploration_manager_chromeos.h View 4 chunks +7 lines, -0 lines 0 comments Download
M ash/ash_touch_exploration_manager_chromeos.cc View 1 2 chunks +21 lines, -1 line 0 comments Download
M ash/common/accessibility_delegate.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ash/common/default_accessibility_delegate.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/default_accessibility_delegate.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_high.wav View Binary file 0 comments Download
A chrome/browser/resources/chromeos/sounds/spoken_feedback_toggle_countdown_low.wav View Binary file 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chromeos/audio/chromeos_sounds.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A ui/chromeos/touch_accessibility_enabler.h View 1 chunk +119 lines, -0 lines 0 comments Download
A ui/chromeos/touch_accessibility_enabler.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A ui/chromeos/touch_accessibility_enabler_unittest.cc View 1 chunk +181 lines, -0 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 3 chunks +9 lines, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
dmazzoni
@xiyuan: could you please review the differences between patch set 1 and patch set 2, ...
4 years ago (2016-12-16 23:35:08 UTC) #6
xiyuan
CfM testing part lgtm
4 years ago (2016-12-19 20:43:17 UTC) #10
dmazzoni
+TBR=oshima,sadrul,michaelpg (original reviewers) since this is a re-land.
4 years ago (2016-12-19 22:03:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584063002/20001
4 years ago (2016-12-19 22:06:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 23:28:30 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-19 23:31:27 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16d2dec10b4a9ae2259658a474cd6867f82d08e3
Cr-Commit-Position: refs/heads/master@{#439611}

Powered by Google App Engine
This is Rietveld 408576698