Toggle spoken feedback if two fingers are held down.

Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d
Cr-Commit-Position: refs/heads/master@{#432129}

[dmazzoni, 2016-11-04 19:53:20]

Description was changed from

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
==========

to

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-11-04 19:53:25]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-04 19:54:19]

dmazzoni@chromium.org changed reviewers:
+ oshima@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:21:44]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-11-08 18:14:43]

https://codereview.chromium.org/2476843003/diff/1/ash/common/accessibility_de...
File ash/common/accessibility_delegate.h (right):

https://codereview.chromium.org/2476843003/diff/1/ash/common/accessibility_de...
ash/common/accessibility_delegate.h:127: // is about to happen.
You have very similar comments in three places. 
How about keeping the comment minimum here (what implementation should do)?

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:553: }
nuke {}

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:565: // spoken
feedback.
and consolidate this with the comment in the header. (whichever you like)

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:23: const int kTimerDelayInMS = 500;
nit: constexpr

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:37: DCHECK(root_window);
delegate too?

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:47: std::unique_ptr<ui::Event>*
rewritten_event) {
so eventhandler doesn't work?

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.h (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:37: virtual void
PlaySpokenFeedbackToggleCountdown(int tick_count) = 0;
optional: you may have empty impl for void functions in pure interface.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:47: explicit
TouchAccessibilityEnabler(
nit: remove explicit

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:60: protected:
is there subclass for this?

[dmazzoni, 2016-11-08 20:43:32]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-11-08 20:43:47]

https://codereview.chromium.org/2476843003/diff/1/ash/common/accessibility_de...
File ash/common/accessibility_delegate.h (right):

https://codereview.chromium.org/2476843003/diff/1/ash/common/accessibility_de...
ash/common/accessibility_delegate.h:127: // is about to happen.
On 2016/11/08 18:14:43, oshima wrote:
> You have very similar comments in three places. 
> How about keeping the comment minimum here (what implementation should do)?

Made it more concise in 2/3 places

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:553: }
On 2016/11/08 18:14:43, oshima wrote:
> nuke {}

Done.

https://codereview.chromium.org/2476843003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:565: // spoken
feedback.
On 2016/11/08 18:14:43, oshima wrote:
> and consolidate this with the comment in the header. (whichever you like)

Removed this one, I'll just leave the main comment where this is called

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:23: const int kTimerDelayInMS = 500;
On 2016/11/08 18:14:43, oshima wrote:
> nit: constexpr

Done.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:37: DCHECK(root_window);
On 2016/11/08 18:14:43, oshima wrote:
> delegate too?

Done.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:47: std::unique_ptr<ui::Event>*
rewritten_event) {
On 2016/11/08 18:14:43, oshima wrote:
> so eventhandler doesn't work?

Oh, good catch! Originally I did rewrite an event but I didn't
need to after all. Switched to EventHandler using AddPreTargetHandler
and confirmed that it works.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.h (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:37: virtual void
PlaySpokenFeedbackToggleCountdown(int tick_count) = 0;
On 2016/11/08 18:14:43, oshima wrote:
> optional: you may have empty impl for void functions in pure interface.

Done.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:47: explicit
TouchAccessibilityEnabler(
On 2016/11/08 18:14:43, oshima wrote:
> nit: remove explicit

Done.

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.h:60: protected:
On 2016/11/08 18:14:43, oshima wrote:
> is there subclass for this?

No, changed to private.

[commit-bot: I haz the power, 2016-11-08 20:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-08 21:18:04]

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:47: std::unique_ptr<ui::Event>*
rewritten_event) {
On 2016/11/08 20:43:47, dmazzoni wrote:
> On 2016/11/08 18:14:43, oshima wrote:
> > so eventhandler doesn't work?
> 
> Oh, good catch! Originally I did rewrite an event but I didn't
> need to after all. Switched to EventHandler using AddPreTargetHandler
> and confirmed that it works.

Actually after testing some more, it doesn't work as an EventHandler.
It works for toggling it on, but toggling spoken feedback on installs
a different EventRewriter for touch accessibility, and that rewrites
all of the events before any EventHandlers get them - so we can't
toggle off.

I think it's simpler to just make this an EventRewriter. I added
a comment explaining why.

[dmazzoni, 2016-11-08 21:18:45]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 21:19:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 22:29:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:29:28]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-11-09 23:45:39]

Description was changed from

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oshima, 2016-11-09 23:45:39]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2016-11-09 23:48:32]

On 2016/11/08 21:18:04, dmazzoni wrote:
>
https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
> File ui/chromeos/touch_accessibility_enabler.cc (right):
> 
>
https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
> ui/chromeos/touch_accessibility_enabler.cc:47: std::unique_ptr<ui::Event>*
> rewritten_event) {
> On 2016/11/08 20:43:47, dmazzoni wrote:
> > On 2016/11/08 18:14:43, oshima wrote:
> > > so eventhandler doesn't work?
> > 
> > Oh, good catch! Originally I did rewrite an event but I didn't
> > need to after all. Switched to EventHandler using AddPreTargetHandler
> > and confirmed that it works.
> 
> Actually after testing some more, it doesn't work as an EventHandler.
> It works for toggling it on, but toggling spoken feedback on installs
> a different EventRewriter for touch accessibility, and that rewrites
> all of the events before any EventHandlers get them - so we can't
> toggle off.
> 
> I think it's simpler to just make this an EventRewriter. I added
> a comment explaining why.

I'm fine if there is no other good way, but want to hear sadrul@'s opinion.
sadrul@, do you have any recommendation?

[sadrul, 2016-11-10 20:39:03]

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/1/ui/chromeos/touch_accessibi...
ui/chromeos/touch_accessibility_enabler.cc:47: std::unique_ptr<ui::Event>*
rewritten_event) {
On 2016/11/08 21:18:04, dmazzoni wrote:
> On 2016/11/08 20:43:47, dmazzoni wrote:
> > On 2016/11/08 18:14:43, oshima wrote:
> > > so eventhandler doesn't work?
> > 
> > Oh, good catch! Originally I did rewrite an event but I didn't
> > need to after all. Switched to EventHandler using AddPreTargetHandler
> > and confirmed that it works.
> 
> Actually after testing some more, it doesn't work as an EventHandler.
> It works for toggling it on, but toggling spoken feedback on installs
> a different EventRewriter for touch accessibility, and that rewrites
> all of the events before any EventHandlers get them - so we can't
> toggle off.
> 
> I think it's simpler to just make this an EventRewriter. I added
> a comment explaining why.

I would like to understand more, because this is a misuse of the rewriter API.

What is the event-rewriter that gets installed with spoken feedback? Can that
notify this handler before it does the rewrite?

[dmazzoni, 2016-11-10 21:03:43]

On 2016/11/10 20:39:03, sadrul wrote:
> I would like to understand more, because this is a misuse of the rewriter API.
> 
> What is the event-rewriter that gets installed with spoken feedback? Can that
> notify this handler before it does the rewrite?

ui/chromeos/touch_exploration_controller.h

When spoken feedback is enabled, TouchExplorationController gets installed,
and that one really is an event rewriter. It implements the same basic
accessible touch screen strategy used on other platforms: touching the
screen speaks what's under your finger, then double-tapping
actually clicks. In TouchExplorationController, we rewrite a
single-finger touch event as a mouse move, and a two-finger touch event
as a single-finger touch event, and more.

If TouchAccessibilityEnabler is an EventHandler instead of an
EventRewriter, it would need to deal with two possible inputs -
either unrewritten events when TouchExplorationController is off,
or rewritten events when TouchExplorationController is on.

I guess my question is whether that added complexity is better
than the mild abuse of the event rewriter API.

Another option would be to combine both classes into a single
EventRewriter that dispatches to both bits of logic.

[dmazzoni, 2016-11-10 23:10:50]

On 2016/11/10 20:39:03, sadrul wrote:
> Can that notify this handler before it does the rewrite?

OK, I tried something along those lines. Take a look.

[dmazzoni, 2016-11-10 23:11:15]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:12:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:30:12]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[sadrul, 2016-11-12 01:51:53]

This looks much better! A couple of nits, other than that, lgtm

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
ui/chromeos/touch_accessibility_enabler.cc:91: if (touch_ids_.size() > 2) {
I think you can just use |touch_locations_| to track the active touch-points,
and don't actually need |touch_ids_|.

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
File ui/chromeos/touch_accessibility_enabler.h (right):

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
ui/chromeos/touch_accessibility_enabler.h:59: void HandleTouchEvent(const
ui::TouchEvent* event);
const ref

[dmazzoni, 2016-11-14 20:33:27]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-11-14 20:33:54]

Thanks! @oshima, any last thoughts from you?

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
ui/chromeos/touch_accessibility_enabler.cc:91: if (touch_ids_.size() > 2) {
On 2016/11/12 01:51:53, sadrul wrote:
> I think you can just use |touch_locations_| to track the active touch-points,
> and don't actually need |touch_ids_|.

Good idea, done.

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
File ui/chromeos/touch_accessibility_enabler.h (right):

https://codereview.chromium.org/2476843003/diff/60001/ui/chromeos/touch_acces...
ui/chromeos/touch_accessibility_enabler.h:59: void HandleTouchEvent(const
ui::TouchEvent* event);
On 2016/11/12 01:51:53, sadrul wrote:
> const ref

Done.

[commit-bot: I haz the power, 2016-11-14 20:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-11-14 21:42:59]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 21:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-11-14 22:02:47]

lgtm

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler.cc:53: void
TouchAccessibilityEnabler::HandleTouchEvent(const ui::TouchEvent& event) {
DCHECK(!(event.flags() & EF_TOUCH_ACCESSIBILITY)); ?

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler.cc:134: int tick_count =
roundf(tick_count_f);
nit: include <math.h>

or use std::lround

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
File ui/chromeos/touch_accessibility_enabler_unittest.cc (right):

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler_unittest.cc:39: };
nit: DISALLOW_COPY_AND_ASSIGN

[commit-bot: I haz the power, 2016-11-14 22:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:57:03]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2016-11-14 23:16:41]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-11-14 23:16:59]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2016-11-14 23:17:16]

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
File ui/chromeos/touch_accessibility_enabler.cc (right):

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler.cc:53: void
TouchAccessibilityEnabler::HandleTouchEvent(const ui::TouchEvent& event) {
On 2016/11/14 22:02:47, oshima wrote:
> DCHECK(!(event.flags() & EF_TOUCH_ACCESSIBILITY)); ?

Done.

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler.cc:134: int tick_count =
roundf(tick_count_f);
On 2016/11/14 22:02:47, oshima wrote:
> nit: include <math.h>
> 
> or use std::lround

Done.

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
File ui/chromeos/touch_accessibility_enabler_unittest.cc (right):

https://codereview.chromium.org/2476843003/diff/100001/ui/chromeos/touch_acce...
ui/chromeos/touch_accessibility_enabler_unittest.cc:39: };
On 2016/11/14 22:02:47, oshima wrote:
> nit: DISALLOW_COPY_AND_ASSIGN

Done.

[dmazzoni, 2016-11-14 23:17:23]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-11-14 23:17:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2476843003/#ps120001
(title: "Address last nits")

[commit-bot: I haz the power, 2016-11-14 23:18:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:34:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dmazzoni, 2016-11-15 01:23:42]

dmazzoni@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dmazzoni, 2016-11-15 01:23:43]

+michaelpg for chrome/browser/browser_resources.grd and
chrome/browser/resources/chromeos/sounds

[michaelpg, 2016-11-15 03:15:12]

lgtm for chrome/browser/browser_resources.grd and
chrome/browser/resources/chromeos/sounds

[dmazzoni, 2016-11-15 06:15:49]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-11-15 06:16:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 06:21:21]

Description was changed from

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-15 06:21:23]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-15 06:23:16]

Description was changed from

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Toggle spoken feedback if two fingers are held down.

Blind users need a way to toggle spoken feedback on devices that only
have a touch screen, and devices that are temporarily in a mode where
the keyboard is disabled.

Add a class that watches for two fingers held down, plays a tick sound
to let the user know something might happen, then toggles spoken feedback
if two fingers remain down without moving for enough time.

BUG=662501
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d
Cr-Commit-Position: refs/heads/master@{#432129}
==========

[commit-bot: I haz the power, 2016-11-15 06:23:18]

Patchset 7 (id:??) landed as
https://crrev.com/e648c7373d2a3bffb6e39bcab1ef1d7441e5ee7d
Cr-Commit-Position: refs/heads/master@{#432129}