Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2583733003: Use LayoutObject::subtreeNeedsPaintPropertyUpdate for printing invalidation (Closed)
Patch Set: - Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 4e0f8ed2b1c1d56924667baec14a48a188c1bf5a..6f8b92d5fa94e0ffa60f2a701eb4a7ffe135c4f8 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -756,17 +756,9 @@ class CORE_EXPORT FrameView final
}
bool needsPaintPropertyUpdate() const { return m_needsPaintPropertyUpdate; }
- // Set when the whole frame subtree needs full paint invalidation and paint
- // property update, e.g. when beginning or finishing printing.
- void setShouldInvalidateAllPaintAndPaintProperties() {
- m_shouldInvalidateAllPaintAndPaintProperties = true;
- }
- void clearShouldInvalidateAllPaintAndPaintProperties() {
- m_shouldInvalidateAllPaintAndPaintProperties = true;
- }
- bool shouldInvalidateAllPaintAndPaintProperties() const {
- return m_shouldInvalidateAllPaintAndPaintProperties;
- }
+ // Set when the whole frame subtree needs full paint property update,
+ // e.g. when beginning or finishing printing.
+ void setSubtreeNeedsPaintPropertyUpdate();
// TODO(ojan): Merge this with IntersectionObserver once it lands.
IntRect computeVisibleArea();
@@ -1147,7 +1139,6 @@ class CORE_EXPORT FrameView final
// Whether the paint properties need to be updated. For more details, see
// FrameView::needsPaintPropertyUpdate().
bool m_needsPaintPropertyUpdate;
- bool m_shouldInvalidateAllPaintAndPaintProperties;
// This is set on the local root frame view only.
DocumentLifecycle::LifecycleState m_currentUpdateLifecyclePhasesTargetState;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698