Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2583633002: Update Data Reduction Proxy promo strings (Closed)

Created:
4 years ago by megjablon
Modified:
4 years ago
Reviewers:
Maria
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Data Reduction Proxy promo strings Update the stings for the first and second run Data Reduction Proxy promos. BUG=674645 Committed: https://crrev.com/28defc0e8931e961d19ea231b0b5c28e524781f1 Cr-Commit-Position: refs/heads/master@{#439170}

Patch Set 1 #

Patch Set 2 : new string discussed offline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
megjablon
PTAL, thanks!
4 years ago (2016-12-15 20:00:48 UTC) #2
Maria
lgtm
4 years ago (2016-12-15 20:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583633002/1
4 years ago (2016-12-15 21:03:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583633002/20001
4 years ago (2016-12-16 18:58:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 19:50:46 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 19:52:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28defc0e8931e961d19ea231b0b5c28e524781f1
Cr-Commit-Position: refs/heads/master@{#439170}

Powered by Google App Engine
This is Rietveld 408576698