Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2583493003: Password Manager: skip non-text fields from consideration for filling. (Closed)

Created:
4 years ago by dvadym
Modified:
4 years ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Password Manager: skip non-text fields from consideration for filling. BUG=619345 Committed: https://crrev.com/78408cfeaad0b8657041a0e6b75df24e93229924 Cr-Commit-Position: refs/heads/master@{#438868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/test/data/password/ambiguous_password_form.html View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
dvadym
Hi Vaclav, could you please review this CL? Regards, Vadym
4 years ago (2016-12-15 14:47:29 UTC) #3
vabr (Chromium)
Very nice! Test and fix each line, like a haiku! :) LGTM. Cheers, Vaclav
4 years ago (2016-12-15 14:59:03 UTC) #5
vabr (Chromium)
On 2016/12/15 14:59:03, vabr (Chromium) wrote: > Very nice! > > Test and fix each ...
4 years ago (2016-12-15 15:00:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583493003/1
4 years ago (2016-12-15 15:19:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 17:45:55 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 17:47:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78408cfeaad0b8657041a0e6b75df24e93229924
Cr-Commit-Position: refs/heads/master@{#438868}

Powered by Google App Engine
This is Rietveld 408576698