components/autofill/content/renderer/password_autofill_agent.cc - Issue 2583493003: Password Manager: skip non-text fields from consideration for filling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2583493003: Password Manager: skip non-text fields from consideration for filling. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index 88f28df670b44d069a026b7111b6e7c0986851a1..5163c56b0c09820b7f9b2b12211618c4c385297f 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -177,7 +177,8 @@ bool FindFormInputElement(

// fields.

const blink::WebInputElement input_element =

control_element.toConst<blink::WebInputElement>();

- if (input_element.isPasswordField() != is_password_field)

+ if (!input_element.isTextField() ||

+ input_element.isPasswordField() != is_password_field)

continue;

// For change password form with ambiguous or empty names keep only the

« no previous file with comments | « chrome/test/data/password/ambiguous_password_form.html ('k') | no next file » | no next file with comments »