Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ash/common/system/system_notifier.cc

Issue 2583393002: Send notification to users upon receiving sms messages (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/system_notifier.cc
diff --git a/ash/common/system/system_notifier.cc b/ash/common/system/system_notifier.cc
index 8150e7882a2b13a78625ff64a9a0a5ea0dd90800..5dd9a392c49e202f6c487509920ea606fe2f740d 100644
--- a/ash/common/system/system_notifier.cc
+++ b/ash/common/system/system_notifier.cc
@@ -19,9 +19,11 @@ namespace {
// screen.
const char* kAlwaysShownSystemNotifierIds[] = {
kNotifierAccessibility, kNotifierDeprecatedAccelerator, kNotifierBattery,
- kNotifierDisplay, kNotifierDisplayError,
- kNotifierNetworkError,
+ kNotifierDisplay, kNotifierDisplayError, kNotifierNetworkError,
kNotifierPower,
+#if defined(OS_CHROMEOS)
+ kNotifierSms,
tdanderson 2017/01/26 22:19:07 Why does this need to be ifdefed for CrOS?
yiyix 2017/02/02 20:43:56 No sms will be received for no-CrOS? This block of
tdanderson 2017/02/07 00:15:45 Thanks, the way you have it in Patch set 2 looks g
+#endif
// Note: Order doesn't matter here, so keep this in alphabetic order, don't
// just add your stuff at the end!
NULL};
@@ -73,6 +75,7 @@ const char kNotifierScreenshot[] = "ash.screenshot";
const char kNotifierScreenCapture[] = "ash.screen-capture";
const char kNotifierScreenShare[] = "ash.screen-share";
const char kNotifierSessionLengthTimeout[] = "ash.session-length-timeout";
+const char kNotifierSms[] = "ash.sms";
const char kNotifierSupervisedUser[] = "ash.locally-managed-user";
const char kNotifierWebUsb[] = "ash.webusb";

Powered by Google App Engine
This is Rietveld 408576698