Send notification to users upon receiving sms messages

ash/common/system/system_notifier.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/system_notifier.h"
 
 #include "base/logging.h"
 
 namespace ash {
 namespace system_notifier {
 
 namespace {
 
 // See http://dev.chromium.org/chromium-os/chromiumos-design-docs/
 // system-notifications for the reasoning.
 
 // |kAlwaysShownSystemNotifierIds| is the list of system notification sources
 // which can appear regardless of the situation, such like login screen or lock
 // screen.
 const char* kAlwaysShownSystemNotifierIds[] = {
     kNotifierAccessibility, kNotifierDeprecatedAccelerator, kNotifierBattery,
-    kNotifierDisplay, kNotifierDisplayError,
-    kNotifierNetworkError,
+    kNotifierDisplay, kNotifierDisplayError, kNotifierNetworkError,
     kNotifierPower,
+#if defined(OS_CHROMEOS)
+    kNotifierSms,

[tdanderson, 2017/01/26 22:19:07]

Why does this need to be ifdefed for CrOS?

[yiyix, 2017/02/02 20:43:56]

No sms will be received for no-CrOS? This block of code has been modified since
i made the change. It had something like:
#if defined(OS_CHROMEOS)
    kNotifierNetworkError,
#endif
(example: the diff in this cl, https://codereview.chromium.org/2487463003)
Sorry, I didn't merge it too carefully. 

[tdanderson, 2017/02/07 00:15:45]

Thanks, the way you have it in Patch set 2 looks good.

+#endif
     // Note: Order doesn't matter here, so keep this in alphabetic order, don't
     // just add your stuff at the end!
     NULL};
 
 // |kAshSystemNotifiers| is the list of normal system notification sources for
 // ash events. These notifications can be hidden in some context.
 const char* kAshSystemNotifiers[] = {
     kNotifierBluetooth, kNotifierDisplayResolutionChange, kNotifierDisk,
     kNotifierLocale, kNotifierMultiProfileFirstRun, kNotifierNetwork,
     kNotifierNetworkPortalDetector, kNotifierScreenshot, kNotifierScreenCapture,
@@ skipping 31 matching lines @@
 const char kNotifierMultiProfileFirstRun[] = "ash.multi-profile.first-run";
 const char kNotifierNetwork[] = "ash.network";
 const char kNotifierNetworkError[] = "ash.network.error";
 const char kNotifierNetworkPortalDetector[] = "ash.network.portal-detector";
 const char kNotifierPower[] = "ash.power";
 const char kNotifierQuickUnlock[] = "ash.quickunlock";
 const char kNotifierScreenshot[] = "ash.screenshot";
 const char kNotifierScreenCapture[] = "ash.screen-capture";
 const char kNotifierScreenShare[] = "ash.screen-share";
 const char kNotifierSessionLengthTimeout[] = "ash.session-length-timeout";
+const char kNotifierSms[] = "ash.sms";
 const char kNotifierSupervisedUser[] = "ash.locally-managed-user";
 const char kNotifierWebUsb[] = "ash.webusb";
 
 bool ShouldAlwaysShowPopups(const message_center::NotifierId& notifier_id) {
   return MatchSystemNotifierId(notifier_id, kAlwaysShownSystemNotifierIds);
 }
 
 bool IsAshSystemNotifier(const message_center::NotifierId& notifier_id) {
   return ShouldAlwaysShowPopups(notifier_id) ||
          MatchSystemNotifierId(notifier_id, kAshSystemNotifiers);
 }
 
 }  // namespace system_notifier
 }  // namespace ash