Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2487463003: Add Search+Shift+H as global shortcut to toggle high contrast mode. (Closed)

Created:
4 years, 1 month ago by dmazzoni
Modified:
4 years, 1 month ago
Reviewers:
James Cook, jennyz
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Search+Shift+H as global shortcut to toggle high contrast mode. Originally we landed Ctrl+Alt+H as the shortcut, but this was reverted as it conflicted with too many apps, and we didn't want it to be overridable. We're going to migrate all accessibility toggles to Search+Shift+Letter. This change also adds a notification to aid users who press it by accident. BUG=644758 Committed: https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9 Cr-Commit-Position: refs/heads/master@{#431897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_controller.cc View 5 chunks +38 lines, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M ash/common/system/system_notifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/system_notifier.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dmazzoni
Hi Jenny, could you review ash/common/system and the notification code before I get an owners ...
4 years, 1 month ago (2016-11-08 00:19:07 UTC) #2
jennyz
lgtm
4 years, 1 month ago (2016-11-10 21:42:09 UTC) #7
dmazzoni
+jamescook for owners review of ash/
4 years, 1 month ago (2016-11-10 22:07:49 UTC) #8
dmazzoni
Oops, actually adding James
4 years, 1 month ago (2016-11-14 16:03:33 UTC) #10
James Cook
LGTM
4 years, 1 month ago (2016-11-14 17:06:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487463003/1
4 years, 1 month ago (2016-11-14 17:15:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 19:21:47 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 20:09:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac88b53fda73316cf2021fc18afbb4e496a4d9c9
Cr-Commit-Position: refs/heads/master@{#431897}

Powered by Google App Engine
This is Rietveld 408576698