Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 2583333002: Revert of Dont post delayed DoWork for disabled queues. (Closed)

Created:
4 years ago by gab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dont post delayed DoWork for disabled queues. (patchset #5 id:80001 of https://codereview.chromium.org/2572893002/ ) Reason for revert: Need to revert this to be able to revert https://codereview.chromium.org/2546423002 which is the #1 culprit for http://crbug.com/674895. Original issue's description: > Dont post delayed DoWork for disabled queues. We could do this for fences too but don't > because that would break the throttling logic which needs to know when the next delayed > task is due to be run. > > BUG=671669 > > Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483 > Cr-Commit-Position: refs/heads/master@{#438962} TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671669, 674895 Committed: https://crrev.com/a4d8806c8b5ecf364370325e597aa4f85d30c01f Cr-Commit-Position: refs/heads/master@{#439621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -229 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 2 chunks +6 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 2 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.cc View 2 chunks +7 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc View 8 chunks +34 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
gab
Created Revert of Dont post delayed DoWork for disabled queues.
4 years ago (2016-12-19 19:44:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583333002/1
4 years ago (2016-12-19 19:44:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/201915)
4 years ago (2016-12-19 21:39:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583333002/1
4 years ago (2016-12-19 22:53:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 23:50:13 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4d8806c8b5ecf364370325e597aa4f85d30c01f Cr-Commit-Position: refs/heads/master@{#439621}
4 years ago (2016-12-19 23:52:29 UTC) #13
haraken
4 years ago (2016-12-20 00:00:12 UTC) #14
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698