Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc

Issue 2583333002: Revert of Dont post delayed DoWork for disabled queues. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
index 53d97289fe725e6014aa4a62ee109142847c56d8..79e17b6869ca2ffc83ad70616b1f966997a82e88 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
@@ -2413,65 +2413,5 @@
run_loop.Run();
}
-TEST_F(TaskQueueManagerTest, DelayedDoWorkNotPostedForDisabledQueue) {
- Initialize(1u);
-
- runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask),
- base::TimeDelta::FromMilliseconds(1));
- ASSERT_TRUE(test_task_runner_->HasPendingTasks());
- EXPECT_EQ(base::TimeDelta::FromMilliseconds(1),
- test_task_runner_->DelayToNextTaskTime());
-
- std::unique_ptr<TaskQueue::QueueEnabledVoter> voter =
- runners_[0]->CreateQueueEnabledVoter();
- voter->SetQueueEnabled(false);
-
- EXPECT_TRUE(test_task_runner_->HasPendingTasks());
- test_task_runner_->RemoveCancelledTasks();
- EXPECT_FALSE(test_task_runner_->HasPendingTasks());
-
- voter->SetQueueEnabled(true);
- ASSERT_TRUE(test_task_runner_->HasPendingTasks());
- EXPECT_EQ(base::TimeDelta::FromMilliseconds(1),
- test_task_runner_->DelayToNextTaskTime());
-}
-
-TEST_F(TaskQueueManagerTest, DisablingQueuesChangesDelayTillNextDoWork) {
- Initialize(3u);
- runners_[0]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask),
- base::TimeDelta::FromMilliseconds(1));
- runners_[1]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask),
- base::TimeDelta::FromMilliseconds(10));
- runners_[2]->PostDelayedTask(FROM_HERE, base::Bind(&NopTask),
- base::TimeDelta::FromMilliseconds(100));
-
- std::unique_ptr<TaskQueue::QueueEnabledVoter> voter0 =
- runners_[0]->CreateQueueEnabledVoter();
- std::unique_ptr<TaskQueue::QueueEnabledVoter> voter1 =
- runners_[1]->CreateQueueEnabledVoter();
- std::unique_ptr<TaskQueue::QueueEnabledVoter> voter2 =
- runners_[2]->CreateQueueEnabledVoter();
-
- ASSERT_TRUE(test_task_runner_->HasPendingTasks());
- EXPECT_EQ(base::TimeDelta::FromMilliseconds(1),
- test_task_runner_->DelayToNextTaskTime());
-
- voter0->SetQueueEnabled(false);
- test_task_runner_->RemoveCancelledTasks();
- ASSERT_TRUE(test_task_runner_->HasPendingTasks());
- EXPECT_EQ(base::TimeDelta::FromMilliseconds(10),
- test_task_runner_->DelayToNextTaskTime());
-
- voter1->SetQueueEnabled(false);
- test_task_runner_->RemoveCancelledTasks();
- ASSERT_TRUE(test_task_runner_->HasPendingTasks());
- EXPECT_EQ(base::TimeDelta::FromMilliseconds(100),
- test_task_runner_->DelayToNextTaskTime());
-
- voter2->SetQueueEnabled(false);
- test_task_runner_->RemoveCancelledTasks();
- EXPECT_FALSE(test_task_runner_->HasPendingTasks());
-}
-
} // namespace scheduler
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698