Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2583263002: arc: Switch to mojo::edk::CreateParentMessagePipe (Closed)

Created:
4 years ago by Luis Héctor Chávez
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Switch to mojo::edk::CreateParentMessagePipe This change should get rid of the very last mojo::edk::CreateMessagePipe in ARC. BUG=674724 TEST=ARC still boots Review-Url: https://codereview.chromium.org/2583263002 Cr-Commit-Position: refs/heads/master@{#445888} Committed: https://chromium.googlesource.com/chromium/src/+/50abf80ac895397ecf2e35194d2d1b06595a496c

Patch Set 1 #

Patch Set 2 : Slightly tweaked handshake #

Patch Set 3 : Might as well take advantage of iovec to avoid another call to sendmsg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M components/arc/arc_session.cc View 1 2 4 chunks +21 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
Luis Héctor Chávez
hidehiko@ PTAL rockot@ FYI Note that we should *not* land this for at least 6 ...
4 years ago (2016-12-19 17:54:21 UTC) #2
hidehiko
On 2016/12/19 17:54:21, Luis Héctor Chávez wrote: > hidehiko@ PTAL > rockot@ FYI > > ...
4 years ago (2016-12-20 14:12:06 UTC) #3
Luis Héctor Chávez
On 2016/12/20 14:12:06, hidehiko wrote: > On 2016/12/19 17:54:21, Luis Héctor Chávez wrote: > > ...
4 years ago (2016-12-20 14:41:30 UTC) #4
Luis Héctor Chávez
On 2016/12/20 14:41:30, Luis Héctor Chávez wrote: > On 2016/12/20 14:12:06, hidehiko wrote: > > ...
4 years ago (2016-12-20 17:16:40 UTC) #6
Ken Rockot(use gerrit already)
rs lgtm for whenever you're ready to land
3 years, 12 months ago (2016-12-27 18:08:30 UTC) #10
Luis Héctor Chávez
hidehiko@ this is now ready to land since we just branched for M57. PTAL
3 years, 11 months ago (2017-01-23 16:26:17 UTC) #11
hidehiko
lgtm
3 years, 11 months ago (2017-01-24 00:26:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583263002/40001
3 years, 11 months ago (2017-01-25 00:11:00 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:06:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/50abf80ac895397ecf2e35194d2d...

Powered by Google App Engine
This is Rietveld 408576698