Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2596363002: [mojo] Delete RemoteMessagePipeBootstrap (Closed)

Created:
3 years, 12 months ago by Luis Héctor Chávez
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Delete RemoteMessagePipeBootstrap RemoteMessagePipeBootstrap is racy since it has no FIFO relationship with mojo::edk::NodeController. Since there are no more callers of mojo::edk::CreateMessagePipe(), we can simply remove that class and always use mojo::edk::Create{Parent,Child}MessagePipe() instead, which does not suffer from the race. BUG=674724 TEST=git cl try Review-Url: https://codereview.chromium.org/2596363002 Cr-Commit-Position: refs/heads/master@{#446077} Committed: https://chromium.googlesource.com/chromium/src/+/8e3c814a822afe01b3893d48cb0dd7cb4e132b74

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -317 lines) Patch
M mojo/edk/embedder/embedder.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/system/core.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/edk/system/core.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/edk/system/remote_message_pipe_bootstrap.h View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/edk/system/remote_message_pipe_bootstrap.cc View 1 chunk +0 lines, -149 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Luis Héctor Chávez
Had some free time today, so went ahead and did this. PTAL
3 years, 12 months ago (2016-12-22 19:21:22 UTC) #4
Ken Rockot(use gerrit already)
Thanks! LGTM
3 years, 12 months ago (2016-12-27 18:09:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596363002/20001
3 years, 11 months ago (2017-01-25 17:30:00 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 19:13:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e3c814a822afe01b3893d48cb0d...

Powered by Google App Engine
This is Rietveld 408576698