third_party: Add libevdev and gestures.

third_party: Add libevdev and gestures.

This allows more ozone code to be built and tested on non-ChromeOS
machines.

BUG=677267
TEST=built chrome with use_evdev_gestures = true, use_system_libevdev = false, use_system_gestures = false

Review-Url: https://codereview.chromium.org/2583223003
Cr-Commit-Position: refs/heads/master@{#442518}
Committed: https://chromium.googlesource.com/chromium/src/+/968d2048faa36195bf79684cb104aec2399d10ee

[reveman, 2016-12-28 12:00:25]

Description was changed from

==========
third_party: Add libevdev and gestures.

This allows more ozone code to be built and tested on non-ChromeOS
machines.

BUG=
TEST=built chrome with use_evdev_gestures = true, use_system_libevdev = false,
use_system_gestures = false
==========

to

==========
third_party: Add libevdev and gestures.

This allows more ozone code to be built and tested on non-ChromeOS
machines.

BUG=677267
TEST=built chrome with use_evdev_gestures = true, use_system_libevdev = false,
use_system_gestures = false
==========

[corbin8951, 2016-12-28 12:25:46]

corbin8951@gmail.com changed reviewers:
+ corbin8951@gmail.com

[corbin8951, 2016-12-28 12:25:47]

lgtm

[reveman, 2016-12-30 16:15:55]

reveman@chromium.org changed reviewers:
+ adlr@chromium.org, djkurtz@chromium.org
- corbin8951@gmail.com

[reveman, 2017-01-09 07:21:59]

reveman@chromium.org changed reviewers:
+ corbin8951@gmail.com

[reveman, 2017-01-09 07:21:59]

ping for review

[rjkroege, 2017-01-09 19:54:22]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2017-01-09 19:54:22]

ozone lgtm

[Daniel Kurtz, 2017-01-10 03:22:01]

LGTM modulo tiny nit.

https://codereview.chromium.org/2583223003/diff/80001/DEPS
File DEPS (right):

https://codereview.chromium.org/2583223003/diff/80001/DEPS#newcode444
DEPS:444: # ChromeOS touchpad gestures library.
tiny nit: "Chrome OS"  (as in the Wireless Display Software line below).

[reveman, 2017-01-10 04:11:52]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-01-10 04:11:53]

https://codereview.chromium.org/2583223003/diff/80001/DEPS
File DEPS (right):

https://codereview.chromium.org/2583223003/diff/80001/DEPS#newcode444
DEPS:444: # ChromeOS touchpad gestures library.
On 2017/01/10 at 03:22:01, Daniel Kurtz wrote:
> tiny nit: "Chrome OS"  (as in the Wireless Display Software line below).

Done.

[reveman, 2017-01-10 04:11:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
corbin8951@gmail.com, rjkroege@chromium.org, djkurtz@chromium.org
Link to the patchset: https://codereview.chromium.org/2583223003/#ps100001
(title: "ChromeOS -> Chrome OS")

[commit-bot: I haz the power, 2017-01-10 04:12:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:20:38]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484021512896870,
"parent_rev": "6b6cc2b4809e9e7479b03e69b39f613f2de70e0b", "commit_rev":
"968d2048faa36195bf79684cb104aec2399d10ee"}

[commit-bot: I haz the power, 2017-01-10 06:21:11]

Description was changed from

==========
third_party: Add libevdev and gestures.

This allows more ozone code to be built and tested on non-ChromeOS
machines.

BUG=677267
TEST=built chrome with use_evdev_gestures = true, use_system_libevdev = false,
use_system_gestures = false
==========

to

==========
third_party: Add libevdev and gestures.

This allows more ozone code to be built and tested on non-ChromeOS
machines.

BUG=677267
TEST=built chrome with use_evdev_gestures = true, use_system_libevdev = false,
use_system_gestures = false

Review-Url: https://codereview.chromium.org/2583223003
Cr-Commit-Position: refs/heads/master@{#442518}
Committed:
https://chromium.googlesource.com/chromium/src/+/968d2048faa36195bf79684cb104...
==========

[commit-bot: I haz the power, 2017-01-10 06:21:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/968d2048faa36195bf79684cb104...

[Wez, 2017-02-07 02:57:59]

wez@chromium.org changed reviewers:
+ jochen@chromium.org, wez@chromium.org

[Wez, 2017-02-07 02:58:00]

Hallo jochen@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	third_party/gestures/BUILD.gn
	third_party/gestures/LICENSE
	third_party/gestures/OWNERS
	third_party/gestures/README.chromium
	third_party/gestures/include/gestures/gestures.h
	third_party/libevdev/BUILD.gn
	third_party/libevdev/LICENSE
	third_party/libevdev/OWNERS
	third_party/libevdev/README.chromium
Thanks,
Wez

[Lei Zhang, 2017-02-23 20:13:49]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-02-23 20:13:50]

More than just an OWNERS review, did this go all the reviews, however trivial
they may be?
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_th...

[reveman, 2017-02-23 21:26:05]

On 2017/02/23 at 20:13:50, thestig wrote:
> More than just an OWNERS review, did this go all the reviews, however trivial
they may be?
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_th...

As these libs were already third party libs maintained by chromium developers
and used for chromium builds on CrOS I was not expecting that another review
would be needed just to allow them to be built by chromium in addition to the
CrOS build. Let us know if that's still required or if we missed some other
step. I think we have a few other cases where we've done the same thing (e.g.
libdrm) so we would have to address those too.

[Lei Zhang, 2017-02-23 21:40:22]

On 2017/02/23 21:26:05, reveman wrote:
> On 2017/02/23 at 20:13:50, thestig wrote:
> > More than just an OWNERS review, did this go all the reviews, however
trivial
> they may be?
>
https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_th...
> 
> As these libs were already third party libs maintained by chromium developers
> and used for chromium builds on CrOS I was not expecting that another review
> would be needed just to allow them to be built by chromium in addition to the
> CrOS build. Let us know if that's still required or if we missed some other
> step. I think we have a few other cases where we've done the same thing (e.g.
> libdrm) so we would have to address those too.

Ah, I didn't look at the bug report. Only glanced at the CL and didn't realize
they were already used on CrOS.