Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2583193003: Add tests for calling {Suspend,Resume}Renderer() on foreground renderer (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, Sami
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for calling {Suspend,Resume}Renderer() on foreground renderer This is a follow-up CL of crrev.com/2583083002. Make sure that calling these methods doesn't take effect when the renderer is foregrounded. BUG=674784 Committed: https://crrev.com/78811128b957f147a677f72b8df93dd90fc44e1d Cr-Commit-Position: refs/heads/master@{#439774}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
bashi
PTAL
4 years ago (2016-12-20 00:58:49 UTC) #6
haraken
LGTM
4 years ago (2016-12-20 01:24:24 UTC) #7
Sami
lgtm -- many thanks for adding these tests!
4 years ago (2016-12-20 12:11:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583193003/20001
4 years ago (2016-12-20 12:12:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 12:23:55 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-20 12:26:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78811128b957f147a677f72b8df93dd90fc44e1d
Cr-Commit-Position: refs/heads/master@{#439774}

Powered by Google App Engine
This is Rietveld 408576698