Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2583193003: Add tests for calling {Suspend,Resume}Renderer() on foreground renderer (Closed)
Patch Set: typo Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index fb05ed4c915381c0e8d2bd8c1b720450bc7963de..fda7d476ad94669295d2002d59357fa60ebf9e7f 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2285,6 +2285,14 @@ TEST_F(RendererSchedulerImplTest, SuspendRenderer) {
RunUntilIdle();
EXPECT_THAT(run_order,
testing::ElementsAre(std::string("L1"), std::string("T1")));
+
+ run_order.clear();
+ PostTestTasks(&run_order, "D2 T2");
+ // The renderer is foregrounded. Suspending doesn't take effect.
+ scheduler_->SuspendRenderer();
+ RunUntilIdle();
+ EXPECT_THAT(run_order,
+ testing::ElementsAre(std::string("D2"), std::string("T2")));
}
TEST_F(RendererSchedulerImplTest, ResumeRenderer) {
@@ -2336,6 +2344,14 @@ TEST_F(RendererSchedulerImplTest, ResumeRenderer) {
RunUntilIdle();
EXPECT_THAT(run_order,
testing::ElementsAre(std::string("D3"), std::string("T3")));
+
+ run_order.clear();
+ PostTestTasks(&run_order, "D4 T4");
+ // The renderer is foregrounded. Resuming doesn't take effect.
+ scheduler_->ResumeRenderer();
+ RunUntilIdle();
+ EXPECT_THAT(run_order,
+ testing::ElementsAre(std::string("D4"), std::string("T4")));
}
TEST_F(RendererSchedulerImplTest, UseCaseToString) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698