Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2583173002: Revert of [inspector] gracefully handle stack overflows in the inspector. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
kozy, jgruber
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] gracefully handle stack overflows in the inspector. (patchset #13 id:240001 of https://codereview.chromium.org/2510093002/ ) Reason for revert: asan failure: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/10047/steps/Ignition%20-%20turbofan/logs/regress-2318 Original issue's description: > [inspector] gracefully handle stack overflows in the inspector. > > Hopefully we can avoid going through JS at all, so we can avoid this issue. > > R=jgruber@chromium.org, kozyatinskiy@chromium.org > BUG=v8:5654 > > Review-Url: https://codereview.chromium.org/2510093002 > Cr-Commit-Position: refs/heads/master@{#41802} > Committed: https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc914961735b1e TBR=jgruber@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5654 Review-Url: https://codereview.chromium.org/2583173002 Cr-Commit-Position: refs/heads/master@{#41805} Committed: https://chromium.googlesource.com/v8/v8/+/a680b260ed5574c6e2d065b7ee7aca66a7453970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -113 lines) Patch
M src/d8.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/inspector/java-script-call-frame.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/java-script-call-frame.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M src/inspector/v8-debugger.cc View 5 chunks +16 lines, -21 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/debugger/debugger.status View 1 chunk +0 lines, -3 lines 0 comments Download
D test/debugger/regress/regress-2318.js View 1 chunk +0 lines, -72 lines 0 comments Download
M test/debugger/test-api.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-2318.js View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Yang
Created Revert of [inspector] gracefully handle stack overflows in the inspector.
4 years ago (2016-12-19 13:27:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583173002/1
4 years ago (2016-12-19 13:28:02 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 13:28:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a680b260ed5574c6e2d065b7ee7aca66a74...

Powered by Google App Engine
This is Rietveld 408576698