Add CFX_RetainPtr Leak() and Unleak() methods

Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.  Need this to clean
up CPDFXFA_Page and retain ptrs.

Review-Url: https://codereview.chromium.org/2583093003
Committed: https://pdfium.googlesource.com/pdfium/+/4741b291f462c0c4a5de4abf1653c3b3c87b613a

[Tom Sepez, 2016-12-19 21:50:45]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 21:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-19 21:51:37]

Description was changed from

==========
Refcount CPDFXFA_Page with CFX_RetainPtrs

Requires adding Leak() and Unleak() methods to pass pointers
across C-APIs.
==========

to

==========
Refcount CPDFXFA_Page with CFX_RetainPtrs

Requires adding Leak() and Unleak() methods to pass pointers
across C-APIs.

Requires passing object being destroyed in CFX_Observable callback.
==========

[commit-bot: I haz the power, 2016-12-19 22:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 22:08:57]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-20 00:19:36]

Description was changed from

==========
Refcount CPDFXFA_Page with CFX_RetainPtrs

Requires adding Leak() and Unleak() methods to pass pointers
across C-APIs.

Requires passing object being destroyed in CFX_Observable callback.
==========

to

==========
Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.
==========

[Tom Sepez, 2016-12-20 00:21:59]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 00:22:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-20 00:23:32]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org, thestig@chromium.org,
weili@chromium.org

[Tom Sepez, 2016-12-20 00:23:46]

Anyone around?

[Tom Sepez, 2016-12-20 00:24:14]

Description was changed from

==========
Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.
==========

to

==========
Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.  Need this to clean
up CPDFXFA_Page and retain ptrs.
==========

[commit-bot: I haz the power, 2016-12-20 00:32:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 00:32:53]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-12-28 19:35:05]

https://codereview.chromium.org/2583093003/diff/60001/core/fxcrt/cfx_retain_p...
File core/fxcrt/cfx_retain_ptr.h (right):

https://codereview.chromium.org/2583093003/diff/60001/core/fxcrt/cfx_retain_p...
core/fxcrt/cfx_retain_ptr.h:42: void Unleak(T* ptr) { m_pObj.reset(ptr); }
I don't quite understand the needs for these functions. Maybe we shouldn't use
CFX_RetainPtr if we need these functions?

[Tom Sepez, 2017-01-03 20:13:24]

On 2016/12/28 19:35:05, Wei Li wrote:
>
https://codereview.chromium.org/2583093003/diff/60001/core/fxcrt/cfx_retain_p...
> File core/fxcrt/cfx_retain_ptr.h (right):
> 
>
https://codereview.chromium.org/2583093003/diff/60001/core/fxcrt/cfx_retain_p...
> core/fxcrt/cfx_retain_ptr.h:42: void Unleak(T* ptr) { m_pObj.reset(ptr); }
> I don't quite understand the needs for these functions. Maybe we shouldn't use
> CFX_RetainPtr if we need these functions?

We can get rid of these once we hold references to all objects passed back to
the embedder.  In the mean time, this makes things simpler underneath the
embedder API layer itself.

[Wei Li, 2017-01-03 23:08:59]

lgtm for temp references

[Tom Sepez, 2017-01-03 23:39:33]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2017-01-03 23:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 23:58:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483486773730910,
"parent_rev": "d654d7854951e0ed3589fcc34617c7ca593d9e86", "commit_rev":
"4741b291f462c0c4a5de4abf1653c3b3c87b613a"}

[commit-bot: I haz the power, 2017-01-03 23:58:36]

Description was changed from

==========
Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.  Need this to clean
up CPDFXFA_Page and retain ptrs.
==========

to

==========
Add CFX_RetainPtr Leak() and Unleak() methods

Required to pass pointers across C-APIs.  Need this to clean
up CPDFXFA_Page and retain ptrs.

Review-Url: https://codereview.chromium.org/2583093003
Committed:
https://pdfium.googlesource.com/pdfium/+/4741b291f462c0c4a5de4abf1653c3b3c87b...
==========

[commit-bot: I haz the power, 2017-01-03 23:58:37]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/4741b291f462c0c4a5de4abf1653c3b3c87b...