Add CFX_RetainPtr Leak() and Unleak() methods

core/fxcrt/cfx_retain_ptr.h

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CORE_FXCRT_CFX_RETAIN_PTR_H_
 #define CORE_FXCRT_CFX_RETAIN_PTR_H_
 
 #include <memory>
 #include <utility>
 
@@ skipping 19 matching lines @@
 
   void Reset(T* obj = nullptr) {
     if (obj)
       obj->Retain();
     m_pObj.reset(obj);
   }
 
   T* Get() const { return m_pObj.get(); }
   void Swap(CFX_RetainPtr& that) { m_pObj.swap(that.m_pObj); }
 
+  // TODO(tsepez): temporary scaffolding, to be removed.
+  T* Leak() { return m_pObj.release(); }
+  void Unleak(T* ptr) { m_pObj.reset(ptr); }

[Wei Li, 2016/12/28 19:35:04]

I don't quite understand the needs for these functions. Maybe we shouldn't use
CFX_RetainPtr if we need these functions?

+
   CFX_RetainPtr& operator=(const CFX_RetainPtr& that) {
     if (*this != that)
       Reset(that.Get());
     return *this;
   }
 
   bool operator==(const CFX_RetainPtr& that) const {
     return Get() == that.Get();
   }
 
@@ skipping 38 matching lines @@
 // Classes managed by CFX_RetainPtr should have protected (or private)
 // constructors, and should friend this function.
 template <typename T, typename... Args>
 CFX_RetainPtr<T> MakeRetain(Args&&... args) {
   return CFX_RetainPtr<T>(new T(std::forward<Args>(args)...));
 }
 
 }  // namespace pdfium
 
 #endif  // CORE_FXCRT_CFX_RETAIN_PTR_H_