Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2583063004: [layoutng] Add a function to compute the min- and max-content contribution (Closed)

Created:
4 years ago by cbiesinger
Modified:
3 years, 12 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add a function to compute the min- and max-content contribution This will be used inside of ComputeMinAndMaxContentSizes for computing the child's contribution to the parent's min and max content size. R=ikilpatrick@chromium.org BUG=635619 Committed: https://crrev.com/525fb507eb8c97d6b7c05afd17f2e6e9a721f50c Cr-Commit-Position: refs/heads/master@{#440105}

Patch Set 1 #

Patch Set 2 : include margins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 3 chunks +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
cbiesinger
4 years ago (2016-12-19 20:39:19 UTC) #1
ikilpatrick
lgtm, thanks for the comments, they're great.
4 years ago (2016-12-21 06:02:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583063004/20001
3 years, 12 months ago (2016-12-21 13:47:45 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-21 15:20:54 UTC) #19
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 15:23:11 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/525fb507eb8c97d6b7c05afd17f2e6e9a721f50c
Cr-Commit-Position: refs/heads/master@{#440105}

Powered by Google App Engine
This is Rietveld 408576698