Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2582903002: Use scoped REF test helpers for SPv2 and RootLayerScrolls. (Closed)

Created:
4 years ago by wkorman
Modified:
4 years ago
Reviewers:
pdr., Xianzhu
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use scoped REF test helpers for SPv2 and RootLayerScrolls. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/ea23e985e5ceb31a2551511bdc3f336199891fae Cr-Commit-Position: refs/heads/master@{#439337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp View 4 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/VideoPainterTest.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
wkorman
I updated a few of these in http://crrev.com/2578343002 and then found a few other cases. ...
4 years ago (2016-12-16 23:44:46 UTC) #3
Xianzhu
lgtm
4 years ago (2016-12-17 02:04:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582903002/1
4 years ago (2016-12-17 02:05:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/328408)
4 years ago (2016-12-17 02:13:16 UTC) #8
wkorman
+pdr@ for platform/ OWNERS.
4 years ago (2016-12-17 02:17:39 UTC) #10
pdr.
On 2016/12/17 at 02:17:39, wkorman wrote: > +pdr@ for platform/ OWNERS. LGTM
4 years ago (2016-12-17 02:24:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582903002/1
4 years ago (2016-12-17 10:32:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-17 10:36:27 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-17 10:39:22 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea23e985e5ceb31a2551511bdc3f336199891fae
Cr-Commit-Position: refs/heads/master@{#439337}

Powered by Google App Engine
This is Rietveld 408576698