Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2582903002: Use scoped REF test helpers for SPv2 and RootLayerScrolls. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
index c61409dc30a5dbbc7b399ac20c9a7fffe2674b97..3f9df356ba6982bb25a1dbc6edc95935de0d560e 100644
--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
@@ -15,12 +15,12 @@
#include "cc/trees/layer_tree_settings.h"
#include "cc/trees/scroll_node.h"
#include "cc/trees/transform_node.h"
-#include "platform/RuntimeEnabledFeatures.h"
#include "platform/graphics/paint/EffectPaintPropertyNode.h"
#include "platform/graphics/paint/PaintArtifact.h"
#include "platform/graphics/paint/ScrollPaintPropertyNode.h"
#include "platform/testing/PaintPropertyTestHelpers.h"
#include "platform/testing/PictureMatchers.h"
+#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
#include "platform/testing/TestPaintArtifact.h"
#include "platform/testing/WebLayerTreeViewImplForTesting.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -59,15 +59,16 @@ class WebLayerTreeViewWithCompositorFrameSink
}
};
-class PaintArtifactCompositorTestWithPropertyTrees : public ::testing::Test {
+class PaintArtifactCompositorTestWithPropertyTrees
+ : public ::testing::Test,
+ private ScopedSlimmingPaintV2ForTest {
protected:
PaintArtifactCompositorTestWithPropertyTrees()
- : m_taskRunner(new base::TestSimpleTaskRunner),
+ : ScopedSlimmingPaintV2ForTest(true),
+ m_taskRunner(new base::TestSimpleTaskRunner),
m_taskRunnerHandle(m_taskRunner) {}
void SetUp() override {
- RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true);
-
// Delay constructing the compositor until after the feature is set.
m_paintArtifactCompositor = PaintArtifactCompositor::create();
m_paintArtifactCompositor->enableExtraDataForTesting();
@@ -81,8 +82,6 @@ class PaintArtifactCompositorTestWithPropertyTrees : public ::testing::Test {
m_webLayerTreeView->setRootLayer(*m_paintArtifactCompositor->getWebLayer());
}
- void TearDown() override { m_featuresBackup.restore(); }
-
const cc::PropertyTrees& propertyTrees() {
return *m_webLayerTreeView->layerTreeHost()
->GetLayerTree()
@@ -112,7 +111,6 @@ class PaintArtifactCompositorTestWithPropertyTrees : public ::testing::Test {
}
private:
- RuntimeEnabledFeatures::Backup m_featuresBackup;
std::unique_ptr<PaintArtifactCompositor> m_paintArtifactCompositor;
scoped_refptr<base::TestSimpleTaskRunner> m_taskRunner;
base::ThreadTaskRunnerHandle m_taskRunnerHandle;

Powered by Google App Engine
This is Rietveld 408576698