Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2582593005: [turbofan] Remove arguments order independent versions of [Tail]CallStub() from CodeAssembler. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove arguments order independent versions of [Tail]CallStub() from CodeAssembler. ... as they are no longer needed. BUG= Review-Url: https://codereview.chromium.org/2582593005 Cr-Commit-Position: refs/heads/master@{#41750} Committed: https://chromium.googlesource.com/v8/v8/+/d4a7c4bf66aa54187f3b4a554fd5fe0caa744ce4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -206 lines) Patch
M src/compiler/code-assembler.h View 3 chunks +0 lines, -31 lines 0 comments Download
M src/compiler/code-assembler.cc View 2 chunks +0 lines, -132 lines 0 comments Download
M src/ic/accessor-assembler.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M src/interpreter/interpreter.cc View 11 chunks +12 lines, -32 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-16 10:12:25 UTC) #4
Michael Starzinger
LGTM. I love it! Awesome!
4 years ago (2016-12-16 10:14:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582593005/1
4 years ago (2016-12-16 10:41:44 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-16 10:43:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d4a7c4bf66aa54187f3b4a554fd5fe0caa7...

Powered by Google App Engine
This is Rietveld 408576698