[Mac] Reverse back/forward toolbar buttons in RTL

[Mac] Reverse back/forward toolbar buttons in RTL

BUG=647206, 673362
Committed: https://crrev.com/1e35b7bb1d2f0ea5bce687a07872277b495428d3
Cr-Commit-Position: refs/heads/master@{#439186}

[lgrey, 2016-12-16 16:59:54]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org

[lgrey, 2016-12-16 16:59:54]

PTAL :)

[Avi (use Gerrit), 2016-12-16 19:17:32]

LGTM though I don't like the naming. Not sure of a good new name tho.

[lgrey, 2016-12-16 19:20:43]

On 2016/12/16 19:17:32, Avi wrote:
> LGTM though I don't like the naming. Not sure of a good new name tho.

For |isRTL| or the the ShouldDo... function?

[Avi (use Gerrit), 2016-12-16 19:24:00]

On 2016/12/16 19:20:43, lgrey wrote:
> On 2016/12/16 19:17:32, Avi wrote:
> > LGTM though I don't like the naming. Not sure of a good new name tho.
> 
> For |isRTL| or the the ShouldDo... function?

The icon names. NAVIGATE_FORWARD doesn't mean that, it is NAVIGATE-RIGHT. We
_should_ have NAVIGATE_FORWARD with automatic mirroring of graphics in RTL mode,
but we don't have that.

The current CL is fine; to address my issue properly would go down a deeeeep
rabbit hole.

[lgrey, 2016-12-16 19:36:29]

The CQ bit was checked by lgrey@chromium.org

[commit-bot: I haz the power, 2016-12-16 19:37:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 20:57:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481916989565170, "parent_rev":
"0237a0fbb417c5f384f6e4dd0aa06606c24e36fb", "commit_rev":
"2e08f6478c8cd800875a54116a0dad038eefd6e6"}

[commit-bot: I haz the power, 2016-12-16 20:57:29]

Description was changed from

==========
[Mac] Reverse back/forward toolbar buttons in RTL

BUG=647206, 673362
==========

to

==========
[Mac] Reverse back/forward toolbar buttons in RTL

BUG=647206, 673362

Review-Url: https://codereview.chromium.org/2582593003
==========

[commit-bot: I haz the power, 2016-12-16 20:57:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-16 20:59:59]

Description was changed from

==========
[Mac] Reverse back/forward toolbar buttons in RTL

BUG=647206, 673362

Review-Url: https://codereview.chromium.org/2582593003
==========

to

==========
[Mac] Reverse back/forward toolbar buttons in RTL

BUG=647206, 673362

Committed: https://crrev.com/1e35b7bb1d2f0ea5bce687a07872277b495428d3
Cr-Commit-Position: refs/heads/master@{#439186}
==========

[commit-bot: I haz the power, 2016-12-16 21:00:01]

Patchset 1 (id:??) landed as
https://crrev.com/1e35b7bb1d2f0ea5bce687a07872277b495428d3
Cr-Commit-Position: refs/heads/master@{#439186}