Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3035)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm

Issue 2582593003: [Mac] Reverse back/forward toolbar buttons in RTL (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
index 0693a2e220d43b5538dbc7f8407d9e2972d83615..a850b3a0d2726fd5d576121d154f3afc3c4368de 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
@@ -7,6 +7,7 @@
#include "base/mac/foundation_util.h"
#include "base/mac/sdk_forward_declarations.h"
#import "chrome/browser/ui/cocoa/image_button_cell.h"
+#import "chrome/browser/ui/cocoa/l10n_util.h"
#import "chrome/browser/ui/cocoa/view_id_util.h"
#include "skia/ext/skia_utils_mac.h"
#import "ui/base/cocoa/nsview_additions.h"
@@ -204,11 +205,14 @@ const NSSize kMDButtonIconSize = NSMakeSize(16, 16);
}
- (gfx::VectorIconId)vectorIconId {
+ BOOL isRTL = cocoa_l10n_util::ShouldDoExperimentalRTLLayout();
switch ([self viewID]) {
case VIEW_ID_BACK_BUTTON:
- return gfx::VectorIconId::NAVIGATE_BACK;
+ return isRTL ? gfx::VectorIconId::NAVIGATE_FORWARD
+ : gfx::VectorIconId::NAVIGATE_BACK;
case VIEW_ID_FORWARD_BUTTON:
- return gfx::VectorIconId::NAVIGATE_FORWARD;
+ return isRTL ? gfx::VectorIconId::NAVIGATE_BACK
+ : gfx::VectorIconId::NAVIGATE_FORWARD;
case VIEW_ID_HOME_BUTTON:
return gfx::VectorIconId::NAVIGATE_HOME;
case VIEW_ID_APP_MENU:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698