Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2582473003: Remove all refs to touchEventFeatureDetection in ScrollingCoordinator. (Closed)

Created:
4 years ago by sunyunjia
Modified:
4 years ago
Reviewers:
mustaq, Rick Byers
CC:
chromium-reviews, blink-layers+watch_chromium.org, kenneth.christiansen, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all refs to touchEventFeatureDetection in ScrollingCoordinator. ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() currently doesn't update the touch rects when TouchEvent feature detection is disabled. This could be bad when scrolling with a touch-action:none region. Since we are always firing touch events, we can remove all refs to touchEventFeatureDetection in ScrollingCoordinator. BUG=671232 Committed: https://crrev.com/4436064358a762936f8da853fc1271e036b96491 Cr-Commit-Position: refs/heads/master@{#438875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sunyunjia
PTAL, thanks!
4 years ago (2016-12-15 17:57:52 UTC) #7
Rick Byers
LGTM
4 years ago (2016-12-15 18:08:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2582473003/1
4 years ago (2016-12-15 18:11:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 18:16:55 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 18:18:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4436064358a762936f8da853fc1271e036b96491
Cr-Commit-Position: refs/heads/master@{#438875}

Powered by Google App Engine
This is Rietveld 408576698