Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2582473003: Remove all refs to touchEventFeatureDetection in ScrollingCoordinator. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index fe04c5a66b7f62cd407af5223674f1da69f07753..c9aff864c2fc5ab2aef09eda942e392dca6a0fdc 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -658,12 +658,6 @@ void ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded() {
TRACE_EVENT0("input",
"ScrollingCoordinator::updateTouchEventTargetRectsIfNeeded");
- // TODO(sunyunjia): remove all refs to touchEvenFeatureDetectionEnabled
- // in this class since we are always firing touch events.
- // crbug.com/671232
- if (!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
- return;
-
// TODO(chrishtr): implement touch event target rects for SPv2.
if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
return;
@@ -732,9 +726,6 @@ void ScrollingCoordinator::setTouchEventTargetRects(
}
void ScrollingCoordinator::touchEventTargetRectsDidChange() {
- if (!RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled())
- return;
-
DCHECK(m_page);
if (!m_page->mainFrame()->isLocalFrame() ||
!m_page->deprecatedLocalMainFrame()->view())
@@ -1040,7 +1031,6 @@ static void accumulateDocumentTouchEventTargetRects(LayerHitTestRects& rects,
void ScrollingCoordinator::computeTouchEventTargetRects(
LayerHitTestRects& rects) {
TRACE_EVENT0("input", "ScrollingCoordinator::computeTouchEventTargetRects");
- DCHECK(RuntimeEnabledFeatures::touchEventFeatureDetectionEnabled());
Document* document = m_page->deprecatedLocalMainFrame()->document();
if (!document || !document->view())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698