server/config: Add test configuration package.

server/config: Add test configuration package.

Add a test configuration package that can bolt on any (read: filesystem
or memory) common/config.Interface implementation for testing.

BUG=chromium:674378
TEST=unit

Review-Url: https://codereview.chromium.org/2582433002
Committed: https://github.com/luci/luci-go/commit/bb51c387acaf3309d1ae17d64dbb1e467f158497

[dnj, 2016-12-15 05:11:16]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2016-12-15 05:11:17]

PTAL. Full stack is:
https://codereview.chromium.org/2580713002 (base)
https://codereview.chromium.org/2578893002 (textproto)
https://codereview.chromium.org/2576993002 (access)
https://codereview.chromium.org/2576343002 (erroring)
https://codereview.chromium.org/2582433002 <-- this
https://codereview.chromium.org/2573403002 (caching)
https://codereview.chromium.org/2575383002 (gaeconfig)
https://codereview.chromium.org/2576923003 (datastore cache)

[iannucci, 2017-01-07 20:32:30]

lgtm

https://codereview.chromium.org/2582433002/diff/1/server/config/testconfig/lo...
File server/config/testconfig/local_service.go (right):

https://codereview.chromium.org/2582433002/diff/1/server/config/testconfig/lo...
server/config/testconfig/local_service.go:95: for i := range cl {
why not `i, cfg` ? it seems like it would be safe since its `[]VALUE` and not
`[]*VALUE`.

[dnj, 2017-01-10 01:50:33]

https://codereview.chromium.org/2582433002/diff/1/server/config/testconfig/lo...
File server/config/testconfig/local_service.go (right):

https://codereview.chromium.org/2582433002/diff/1/server/config/testconfig/lo...
server/config/testconfig/local_service.go:95: for i := range cl {
On 2017/01/07 20:32:30, iannucci wrote:
> why not `i, cfg` ? it seems like it would be safe since its `[]VALUE` and not
> `[]*VALUE`.

b/c "cl" is a slice of config, meaning i, cfg would clone "cfg" even if access
check fails. This way, I only clone once when needed.

[iannucci, 2017-01-11 02:54:43]

lgtm

[dnj, 2017-01-11 20:38:25]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-01-11 20:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 20:46:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484167105685110,
"parent_rev": "efb529dd4da484266debb645d9ac30e8d83f1329", "commit_rev":
"bb51c387acaf3309d1ae17d64dbb1e467f158497"}

[commit-bot: I haz the power, 2017-01-11 20:46:54]

Description was changed from

==========
server/config: Add test configuration package.

Add a test configuration package that can bolt on any (read: filesystem
or memory) common/config.Interface implementation for testing.

BUG=chromium:674378
TEST=unit
==========

to

==========
server/config: Add test configuration package.

Add a test configuration package that can bolt on any (read: filesystem
or memory) common/config.Interface implementation for testing.

BUG=chromium:674378
TEST=unit

Review-Url: https://codereview.chromium.org/2582433002
Committed:
https://github.com/luci/luci-go/commit/bb51c387acaf3309d1ae17d64dbb1e467f158497
==========

[commit-bot: I haz the power, 2017-01-11 20:46:55]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/bb51c387acaf3309d1ae17d64dbb1e467f158497