Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2576343002: server/config: Add an erroring config wrapper. (Closed)

Created:
4 years ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

server/config: Add an erroring config wrapper. Add an erroring config Backend, mirroring that in common/config/filter/erroring. This will replace that package after it is integrated into appengine/gaeconfig. BUG=chromium:674378 TEST=None Review-Url: https://codereview.chromium.org/2576343002 Committed: https://github.com/luci/luci-go/commit/efb529dd4da484266debb645d9ac30e8d83f1329

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A luci_config/server/cfgclient/backend/erroring/erroring.go View 1 1 chunk +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dnj
PTAL. Full stack is: https://codereview.chromium.org/2580713002 (base) https://codereview.chromium.org/2578893002 (textproto) https://codereview.chromium.org/2576993002 (access) https://codereview.chromium.org/2576343002 <-- this https://codereview.chromium.org/2582433002 (test) ...
4 years ago (2016-12-15 05:11:06 UTC) #2
iannucci
lgtm
3 years, 11 months ago (2017-01-07 20:29:57 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2576993002 Patch 20001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-11 03:28:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576343002/20001
3 years, 11 months ago (2017-01-11 14:10:50 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 14:17:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/efb529dd4da484266debb645d9ac30e8d83f1329

Powered by Google App Engine
This is Rietveld 408576698